GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Validate change-notes as a PR check by mario-campos · Pull Request #4116 · github/codeql-action

Conversation

@mario-campos

@mario-campos mario-campos commented Aug 31, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR extends the behavior of the recently added pr-checks/changenotes.mts tool by:

  1. Hardcoding the argument as the newly-added unreleased-change-notes directory, as that is the only destination for change-notes.
  2. Adding a step in the pr-checks.yml workflow file for executing pr-checks/changenotes.mts in PRs to validate any changenotes in unreleased-change-notes.

This PR also introduces an "empty" top-level directory, unreleased-change-notes, to be the destination of future change-note files. This can be changed if another location is more suitable.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • N/A

Products:

  • N/A

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • N/A

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mario-campos
mario-campos requested a review from a team as a code owner August 31, 2026 16:50
Copilot AI balanced review requested due to automatic review settings August 31, 2026 16:50
Copilot started reviewing on behalf of mario-campos August 31, 2026 16:51
View session
@github-actions github-actions Bot added the size/M Should be of average difficulty to review label Aug 31, 2026

This comment was marked as outdated.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos
mario-campos requested a balanced review from Copilot August 31, 2026 18:18
Copilot started reviewing on behalf of mario-campos August 31, 2026 18:19
View session

This comment was marked as outdated.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github github deleted a comment from connected79844 Sep 1, 2026
mbg

This comment was marked as outdated.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos

mario-campos commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Closing this to re-work these changes after a migration to the pr-checks directory. Changes will be pushed to a new PR.

mbg reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos mario-campos closed this Sep 1, 2026
@mbg mbg mentioned this pull request Sep 9, 2026
Migrate changetool to pr-checks #4128
Merged
@mario-campos mario-campos reopened this Sep 11, 2026
@mario-campos
mario-campos marked this pull request as draft September 11, 2026 02:58
@mario-campos
mario-campos force-pushed the mario-campos/validate-cn-workflow branch from f2789ac to ef0cd9e Compare September 11, 2026 03:07
mbg
mbg reviewed Sep 11, 2026
View reviewed changes

@mbg mbg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate that this is a draft pending the changes in the other PRs, but some drive-by comments since I saw this and you could look at incorporating the feedback when updating this PR once the others are merged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread .github/workflows/pr-checks.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread eslint.config.mjs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pr-checks/changelog/validate.mts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos
mario-campos force-pushed the mario-campos/validate-cn-workflow branch from 17bb097 to b652468 Compare September 11, 2026 19:35
@github-actions github-actions Bot added size/S Should be easy to review and removed size/M Should be of average difficulty to review labels Sep 11, 2026
@mario-campos
Extend ESLint rules to *.mts files
b1c1bbb
@mario-campos
mario-campos force-pushed the mario-campos/validate-cn-workflow branch from b652468 to 21b6978 Compare September 11, 2026 19:52
@github-actions github-actions Bot added size/M Should be of average difficulty to review and removed size/S Should be easy to review labels Sep 11, 2026
@mario-campos
mario-campos force-pushed the mario-campos/validate-cn-workflow branch 2 times, most recently from 425de06 to c4bd5c9 Compare September 11, 2026 21:00
mario-campos added 2 commits September 11, 2026 16:04
@mario-campos
Extend changetool to support directories
a691c16
@mario-campos
Validate change-notes in PRs
f60f4d9
This commit also introduces the 'empty' home directory for future change-notes.
@mario-campos
mario-campos force-pushed the mario-campos/validate-cn-workflow branch from c4bd5c9 to f60f4d9 Compare September 11, 2026 21:04
@github-actions github-actions Bot added the size/S Should be easy to review label Sep 11, 2026
@github-actions github-actions Bot removed the size/M Should be of average difficulty to review label Sep 11, 2026
@mario-campos
mario-campos marked this pull request as ready for review September 11, 2026 21:06
@mario-campos
mario-campos requested a review from mbg September 14, 2026 16:11
mbg
mbg previously approved these changes Sep 14, 2026
View reviewed changes

@mbg mbg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, with two non-blocking suggestions for improvements.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread pr-checks/changelog/validate.test.mts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pr-checks/changenotes.mts Resolved

Uh oh!

There was an error while loading. Please reload this page.

mario-campos added 2 commits September 14, 2026 12:17
@mario-campos
Log something on successful changenote validation
f45ef9d
Also, slightly improve the log statement of the validation error case.
@mario-campos
Update validate.test.mts test names to reflect new `isValidAllChangen…
6041eff
…oteFiles`

The `isValidAllChangenoteFiles` now accepts a list of file paths rather than a file path string.
@mario-campos
mario-campos dismissed mbg’s stale review via 6041eff September 14, 2026 18:46
@mario-campos
mario-campos requested a review from mbg September 14, 2026 18:46
mbg
mbg previously approved these changes Sep 15, 2026
View reviewed changes
Comment thread pr-checks/changenotes.mts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos
Be consistent with language and conventions
e26a5c4
@mario-campos
mario-campos dismissed mbg’s stale review via e26a5c4 September 15, 2026 14:18
mbg
mbg approved these changes Sep 16, 2026
View reviewed changes
@mario-campos
mario-campos added this pull request to the merge queue Sep 16, 2026
Merged via the queue into main with commit 9961729 Sep 16, 2026
222 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos
mario-campos deleted the mario-campos/validate-cn-workflow branch September 16, 2026 15:24
This was referenced Sep 18, 2026
Merge main into releases/v4 #4152
Merged
Merge releases/v4 into releases/v3 #4154
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mbg mbg mbg approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/S Should be easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mario-campos @mbg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.