GeezerVison is showing github.com — Migrate `changetool` to `pr-checks` by mbg · Pull Request #4128 · github/codeql-action
Conversation
mbg
commented
Sep 9, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Follow-up to discussion on #4116 which migrates scripts/changetool from its own project to the common pr-checks project to avoid duplicated infrastructure.
Although changetool's two unique dependencies are ESM-only, we simply use the .mts extension for the migrated source files to avoid switching all of pr-checks over to ESM, which would require other modifications.
Risk assessment
For internal use only. Please select the risk level of this change:
- Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.
Which use cases does this change impact?
Environments:
- Testing/None - This change does not impact any CodeQL workflows in production.
How did/will you validate this change?
- Unit tests - I am depending on unit test coverage (i.e. tests in
.test.ts files).
- End-to-end tests - I am depending on PR checks (i.e. tests in
pr-checks).
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
- Development/testing only - This change cannot cause any failures in production.
How will you know if something goes wrong after this change is released?
- Other - Please provide details.
Are there any special considerations for merging or releasing this change?
- No special considerations - This change can be merged at any time.
Merge / deployment checklist
- Confirm this change is backwards compatible with existing workflows.
- Consider adding a changelog entry for this change.
- Confirm the readme and docs have been updated if necessary.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot review overview
🟢 Approval recommended
The migration preserves existing behavior, consolidates infrastructure cleanly, and passes the relevant tests and checks.
Review tier: Balanced
Findings: None
What changed in this PR
Migrates changetool into the shared pr-checks workspace while retaining ESM compatibility through .mts files.
Changes:
- Relocates changelog validation code and tests.
- Consolidates dependencies and TypeScript/ESLint configuration.
- Runs migrated tests through the existing PR-checks job.
| File |
Description |
.github/workflows/pr-checks.yml |
Removes the redundant changetool test job. |
eslint.config.mjs |
Applies PR-checks linting to .mts files. |
package-lock.json |
Updates workspace and dependency resolution. |
package.json |
Removes the separate changetool workspace. |
pr-checks/changelog/validate.mts |
Relocates changelog validation logic. |
pr-checks/changelog/validate.test.mts |
Relocates and adapts validation tests. |
pr-checks/package.json |
Adds changetool dependencies. |
pr-checks/tsconfig.json |
Includes nested TypeScript and .mts sources. |
pr-checks/validate-changelog.mts |
Relocates and renames the CLI entry point. |
scripts/changetool/package.json |
Removes the obsolete standalone package. |
scripts/changetool/tsconfig.json |
Removes the obsolete standalone configuration. |
tsconfig.json |
Removes the deleted project from exclusions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
BTW, Thanks for putting this together for me!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Sep 18, 2026
Reviewers
+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Labels
size/M
Should be of average difficulty to review
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|