GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Migrate `changetool` to `pr-checks` by mbg · Pull Request #4128 · github/codeql-action

Conversation

@mbg

@mbg mbg commented Sep 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Follow-up to discussion on #4116 which migrates scripts/changetool from its own project to the common pr-checks project to avoid duplicated infrastructure.

Although changetool's two unique dependencies are ESM-only, we simply use the .mts extension for the migrated source files to avoid switching all of pr-checks over to ESM, which would require other modifications.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other - Please provide details.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@github-actions github-actions Bot added the size/M Should be of average difficulty to review label Sep 9, 2026
github-advanced-security[bot]
github-advanced-security Bot found potential problems Sep 9, 2026
View reviewed changes
Comment thread pr-checks/changelog/validate.mts Fixed

Uh oh!

There was an error while loading. Please reload this page.

mbg added 3 commits September 9, 2026 11:44
@mbg
Migrate changetool to pr-checks
83d1431
@mbg
Fix some formatting in pr-checks.yml
b136352
@mbg
Address linter errors in validate.test.mts
d235931
@mbg
mbg force-pushed the mbg/move-changetool branch from 19e9e17 to d235931 Compare September 9, 2026 10:44
@mbg
mbg marked this pull request as ready for review September 9, 2026 10:47
Copilot AI balanced review requested due to automatic review settings September 9, 2026 10:48
@mbg
mbg requested a review from a team as a code owner September 9, 2026 10:48
@mbg mbg assigned mario-campos Sep 9, 2026
@mbg
mbg requested review from henrymercer and mario-campos September 9, 2026 10:49
Copilot started reviewing on behalf of mbg September 9, 2026 10:49
View session
Copilot AI reviewed Sep 9, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The migration preserves existing behavior, consolidates infrastructure cleanly, and passes the relevant tests and checks.

Review tier: Balanced
Findings: None

What changed in this PR

Migrates changetool into the shared pr-checks workspace while retaining ESM compatibility through .mts files.

Changes:

  • Relocates changelog validation code and tests.
  • Consolidates dependencies and TypeScript/ESLint configuration.
  • Runs migrated tests through the existing PR-checks job.
File Description
.github/​workflows/​pr-checks.yml Removes the redundant changetool test job.
eslint.config.mjs Applies PR-checks linting to .mts files.
package-lock.json Updates workspace and dependency resolution.
package.json Removes the separate changetool workspace.
pr-checks/​changelog/​validate.mts Relocates changelog validation logic.
pr-checks/​changelog/​validate.test.mts Relocates and adapts validation tests.
pr-checks/​package.json Adds changetool dependencies.
pr-checks/​tsconfig.json Includes nested TypeScript and .mts sources.
pr-checks/​validate-changelog.mts Relocates and renames the CLI entry point.
scripts/​changetool/​package.json Removes the obsolete standalone package.
scripts/​changetool/​tsconfig.json Removes the obsolete standalone configuration.
tsconfig.json Removes the deleted project from exclusions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
mario-campos
mario-campos requested changes Sep 9, 2026
View reviewed changes
Comment thread pr-checks/changelog/validate.test.mts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pr-checks/changelog/validate.test.mts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pr-checks/changelog/validate.test.mts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread pr-checks/validate-changelog.mts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos

mario-campos commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

BTW, Thanks for putting this together for me!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mbg added 2 commits September 10, 2026 16:59
@mbg
Remove unneeded Promise.resolve
aaa0143
@mbg
Merge remote-tracking branch 'origin/main' into mbg/move-changetool
0484c3a
@mbg
mbg requested a review from mario-campos September 10, 2026 16:10
mario-campos
mario-campos approved these changes Sep 10, 2026
View reviewed changes
@mbg
mbg added this pull request to the merge queue Sep 10, 2026
Merged via the queue into main with commit 14c568a Sep 10, 2026
222 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@mbg
mbg deleted the mbg/move-changetool branch September 10, 2026 16:55
@mario-campos mario-campos mentioned this pull request Sep 10, 2026
Move withTmpFile next to withTmpDir #4140
Merged
@mbg mbg mentioned this pull request Sep 11, 2026
Rename validate-changelog to changenotes #4143
Merged
This was referenced Sep 18, 2026
Merge main into releases/v4 #4152
Merged
Merge releases/v4 into releases/v3 #4154
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mario-campos mario-campos mario-campos approved these changes
@henrymercer henrymercer Awaiting requested review from henrymercer
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mario-campos mario-campos

Labels

size/M Should be of average difficulty to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mbg @mario-campos @github-advanced-security
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.