GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Analyze all supported languages in the Linux Arm64 check by redsun82 · Pull Request #4123 · github/codeql-action

Conversation

@redsun82

@redsun82 redsun82 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #4072 (now merged), addressing @mbg's review comments on the Linux Arm64 end-to-end check.

  • Analyze all languages CodeQL supports on Linux Arm64, excluding Swift (macOS only). The check previously only covered javascript,python,go; it now covers cpp,csharp,go,java,javascript,python,ruby, matching the "all languages excluding Swift" set already used by the multi-language autodetect check. Compiled languages are built via the shared multi-language-repo build.sh (which prepare-test swaps into the workspace), and .NET setup was added alongside the existing Go setup.
  • De-duplicate the check's language list. It previously appeared twice (the init languages: input and the assert loop); both now read from a single LANGUAGES env var.
  • Fix a CHANGELOG tense inconsistency: download -> downloads.

pr-checks/checks/linux-arm64.yml is a template, so __linux-arm64.yml was regenerated via pr-checks/sync.sh (only that generated workflow changed).

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • End-to-end tests - The Linux Arm64 PR check exercises the changed template.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other - The Linux Arm64 PR check would fail if a language failed to analyze on arm64.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@redsun82
Address review comments
36cbf13 
- Analyze all languages CodeQL supports on Linux Arm64 (except Swift,
  which is macOS only) in the Linux Arm64 check, building the compiled
  ones via the shared multi-language-repo build.sh
- De-duplicate the check's language list via a shared LANGUAGES env var
  used by both the init input and the assert loop
- Fix CHANGELOG tense: "download" -> "downloads"

Co-authored-by: Copilot App <[email protected]>
Copilot AI balanced review requested due to automatic review settings September 4, 2026 06:31
@redsun82
redsun82 requested a review from a team as a code owner September 4, 2026 06:31
Copilot started reviewing on behalf of redsun82 September 4, 2026 06:31
View session
@github-actions github-actions Bot added the size/XS Should be very easy to review label Sep 4, 2026
Copilot AI reviewed Sep 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

Copilot review overview

🟢 Approval recommended

The focused test-only changes are consistent with existing multi-language checks and introduce no unresolved issues.

Review tier: Balanced
Findings: None

What changed in this PR

Expands the Linux Arm64 end-to-end check to analyze every supported non-Swift language.

Changes:

  • Adds .NET setup and all-language builds.
  • Centralizes the language list in LANGUAGES.
  • Corrects CHANGELOG grammar.
File Description
pr-checks/​checks/​linux-arm64.yml Expands Arm64 language coverage and database assertions.
.github/​workflows/​__linux-arm64.yml Generated workflow; excluded from review.
CHANGELOG.md Corrects verb agreement.
Files excluded by content exclusion policy (1)
  • .github/workflows/__linux-arm64.yml

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github github deleted a comment Sep 4, 2026
@redsun82
redsun82 requested a review from mbg September 4, 2026 07:31
@redsun82
redsun82 enabled auto-merge September 4, 2026 07:32
@redsun82
redsun82 requested a review from henrymercer September 4, 2026 08:06
henrymercer
henrymercer previously approved these changes Sep 4, 2026
View reviewed changes
Comment thread pr-checks/checks/linux-arm64.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@redsun82
redsun82 added this pull request to the merge queue Sep 4, 2026
@henrymercer
henrymercer removed this pull request from the merge queue due to a manual request Sep 4, 2026

Uh oh!

There was an error while loading. Please reload this page.
@henrymercer

henrymercer commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

I've turned off auto merge so you can decide whether you want to address my comment
redsun82 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@redsun82
Log found databases in Linux Arm64 check
16da747 
Log a success line for each language database found in the Linux Arm64 PR check.

Co-authored-by: Copilot App <[email protected]>
@redsun82
redsun82 dismissed henrymercer’s stale review via 16da747 September 4, 2026 10:27
@redsun82
redsun82 requested a review from henrymercer September 4, 2026 11:00
henrymercer
henrymercer approved these changes Sep 4, 2026
View reviewed changes
mbg
mbg approved these changes Sep 4, 2026
View reviewed changes
@henrymercer
henrymercer added this pull request to the merge queue Sep 4, 2026
@henrymercer
henrymercer removed this pull request from the merge queue due to a manual request Sep 4, 2026
@henrymercer
henrymercer added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit 46dfb14 Sep 4, 2026
228 of 230 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@henrymercer
henrymercer deleted the redsun82-address-pr-4072-comments branch September 4, 2026 16:54
This was referenced Sep 9, 2026
Merge main into releases/v4 #4131
Merged
Merge releases/v4 into releases/v3 #4133
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mbg mbg mbg approved these changes
@henrymercer henrymercer henrymercer approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/XS Should be very easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@redsun82 @henrymercer @mbg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.