GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Add support for Linux Arm64 runners by redsun82 · Pull Request #4072 · github/codeql-action Conversation
|
|
@mbg or @henrymercer do you mind giving a very early quick look whether this seems sensible? We can postpone merging until we decide to go with it in the releases. Tomorrow I plan on running some tests by hand on this branch with the nightly release, so I don't mind if the first review is shallow. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks good to start testing! Can we add a PR check based on ubuntu-24.04-arm?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks for preparing these changes! They generally look reasonable. A few points that we'd probably want to tackle on top of them:
sync.ts) Possibly run other e2e tests on arm64 as well.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
- Add darwin/x64 case to linked bundle tests and disambiguate the parametrized test title by platform/arch - Reword CHANGELOG entry to clarify the CLI supports Linux Arm64 - Add a dedicated Linux Arm64 end-to-end PR check on ubuntu-24.04-arm Co-authored-by: Copilot App <[email protected]> Copilot-Session: 308c78bb-53a3-4877-a373-70fab87543f1
…1399) * ci: drop redundant CodeQL scan, fix Scorecard ARM64 incompatibility codeql-action doesn't support Linux ARM64 (upstream: github/codeql-action#4072, #2700), and every codeql "actions" rule already maps to a zizmor audit running on ARM64 in ci.yml, so drop codeql.yml and raise zizmor's min-severity from high to medium to keep equivalent coverage. scorecard-action's amd64-only image has failed every scheduled run on ubuntu-24.04-arm since at least 2026-07-20 (ossf/scorecard-action#1697). Replace it with the checksum-verified linux_arm64 scorecard CLI binary, matching the existing cargo-semver-checks pattern, and upload SARIF via codeql-action/upload-sarif. Closes #1398 Signed-off-by: Hugues Clouâtre <[email protected]> * ci: fix zizmor medium-severity findings surfaced by min-severity change Raising zizmor's min-severity to medium (this PR) surfaces two pre-existing findings unrelated to codeql/scorecard: - dtolnay/rust-toolchain is pinned to the "stable" branch tip but commented "# 1.97.1", which zizmor reads as a mismatched version comment since a branch literally named "1.97.1" points elsewhere. The actual desired version is already set via the "toolchain" input; correct the comment to "# stable" to match what's really pinned (matches the existing correct usage in update-deps.yml). - release.yml and release-repair.yml pass `secrets: inherit` into build-and-attest.yml, which only ever reads the auto-provided GITHUB_TOKEN. Drop the unneeded blanket secret grant. Signed-off-by: Hugues Clouâtre <[email protected]> --------- Signed-off-by: Hugues Clouâtre <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Warning
Adds Linux Arm64 support by recognizing the platform and selecting native CodeQL bundles.
Changes:
| File | Description |
|---|---|
src/cli-errors.ts |
Recognizes Linux Arm64. |
src/cli-errors.test.ts |
Removes Arm64 from unsupported cases. |
src/setup-codeql.ts |
Resolves Arm64 bundle names. |
src/setup-codeql.test.ts |
Tests architecture-specific resolution. |
src/testing-utils.ts |
Updates bundle mocks for Arm64. |
pr-checks/checks/linux-arm64.yml |
Adds an Arm64 integration test. |
CHANGELOG.md |
Announces Arm64 support. |
lib/entry-points.js |
Generated artifact excluded from review. |
.github/workflows/__linux-arm64.yml |
Generated workflow excluded from review. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
- Stub process.platform/arch in the supported-platform test and loop over all supported pairs (including linux/arm64) so it no longer depends on the host - Run the default queries in the Linux Arm64 PR check so the databases are finalized end-to-end Co-authored-by: Copilot App <[email protected]> Copilot-Session: fb7e2d12-6620-4a67-9c1c-4e82f4a5e8d9
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for adding the tests! Just a few very minor things that can mostly be done in follow-ups or don't need to be addressed before merging.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| steps: | ||
| - uses: ./../action/init | ||
| with: | ||
| languages: javascript,python,go |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Minor and doesn't have to be addressed in this PR, but it might be good to analyse all languages that we support on arm64 (ignore if that's already what this list is)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| - name: Assert databases exist | ||
| run: | | ||
| cd "$RUNNER_TEMP/codeql_databases" | ||
| for lang in javascript python go; do |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Minor: It would be nice if the list of languages wasn't duplicated between the init input and here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| ## [UNRELEASED] | ||
|
|
||
| No user facing changes. | ||
| - The CodeQL Action now supports CodeQL releases that are compatible with Linux Arm64 and download the native `linux-arm64` CodeQL bundle when available. [#4072](https://github.com/github/codeql-action/pull/4072) |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Minor: "download" -> "downloads" to make the tense consistent
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@mbg thanks, I'll merge as is for now but spin a follow-up right away 👍 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.