GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||
GeezerVison is showing github.com — Print full PR URLs when OSC 8 hyperlinks are unsupported by skarim · Pull Request #479 · github/gh-stack Conversation
Collaborator
Prints out full PR URLs on terminals that don't support OSC 8 hyperlinks. Supported terminals keep the existing hyperlink behavior with printing PR references. When detected terminal doesn't support, fall back to printing the full URL ( Detection is conservative for tmux, screen, Apple Terminal, Konsole, non-TTY output, and unknown terminals.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pull request overviewAdds plain PR URL fallbacks when OSC 8 hyperlinks are unsupported. Changes:
Show a summary per file
Review details💡 Add a
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page.
Lukeghenco
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
1 task
chadxz
added a commit
to chadxz/prompts
that referenced
this pull request
Why? ==== Human status only shows a pull request number even though its URL is already saved. Printing the URL makes PRs accessible in terminals, redirected output, and logs without terminal hyperlink support. Source: github/gh-stack#479 How? ==== Print each available URL below its branch, keeping old state without a URL readable and leaving the JSON format unchanged. The module's mise //apps/wt-stack:test and :lint passed. Status tests cover open and merged PRs, missing URLs, and plain output without terminal escape sequences. ----
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. gh stack: print full URL to stdout when terminal doesn't support OSC8 hyperlinksUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |