GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feature(repository): add listPullRequestReviews by SimonBarendse · Pull Request #454 · github-tools/github

Conversation

@SimonBarendse

@SimonBarendse SimonBarendse commented Jun 6, 2017

Copy link
Copy Markdown

resolves #453

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mtscout6
mtscout6 requested changes Jul 17, 2017
View reviewed changes

@mtscout6 mtscout6 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for this

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SimonBarendse
SimonBarendse force-pushed the 453_list_pull_request_reviews branch 3 times, most recently from 16724f5 to c73059a Compare September 3, 2017 22:35
@SimonBarendse
feature(repository): add listPullRequestReviews (github-tools#454)
3f9e5a2
@SimonBarendse
SimonBarendse force-pushed the 453_list_pull_request_reviews branch from c73059a to 3f9e5a2 Compare September 3, 2017 23:27
@SimonBarendse SimonBarendse changed the title Add listPullRequestReviews method to Repostitory class feature(repository): add listPullRequestReviews Sep 3, 2017
@SimonBarendse

SimonBarendse commented Sep 10, 2017

Copy link
Copy Markdown
Author

@mtscout6 I've added a test.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@esbanarango

esbanarango commented Sep 26, 2018

Copy link
Copy Markdown

@mtscout6 @SimonBarendse Anything in particular tat prevents this PR to be merged?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@j-rewerts

j-rewerts commented Apr 7, 2019

Copy link
Copy Markdown
Member

I think we've got to get this pointed to an actual test repository that has test reviews on it. @SimonBarendse Could you switch to using the test user for your test?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtscout6 mtscout6 mtscout6 requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

List reviews on a Pull Request

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@SimonBarendse @esbanarango @j-rewerts @mtscout6
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.