Description

HappyEinara

opened on Jul 12, 2020

Issue body actions

The release just now might have broken something.

Steps to reproduce:

• Fresh venv, python3.8
• pip install --upgrade gitpython
• python
  then:

>>> import git
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/vagrant/.virtualenvs/tmpgit/lib/python3.8/site-packages/git/__init__.py", line 41, in <module>
    from git.objects import *               # @NoMove @IgnorePep8
ModuleNotFoundError: No module named 'git.objects'

Activity

1. michalbarer1 commented on Jul 12, 2020

   

   michalbarer1

   on Jul 12, 2020

   More actions

   I got the same error
2. Byron commented on Jul 12, 2020

   

   Byron

   on Jul 12, 2020

   Member

   More actions

   Definitely related to the changes coming from #1028 , could @priv-kweihmann have a look?
   The tar archive definitely has the 'git/objects' directory, so I am a bit surprised it doesn't get installed.

   As immediate action I am rolling the change back.
3. p0tr3c commented on Jul 12, 2020

   

   p0tr3c

   on Jul 12, 2020

   More actions

   same here :-(
4. Byron

   added a commit that references this issue on Jul 12, 2020

   Revert moving tests out of 'git' folder, related to #1030

   d5f0d48
5. Byron commented on Jul 12, 2020

   

   Byron

   on Jul 12, 2020

   Member

   More actions

   v3.1.5 was released with the PR in question reverted. My apologies for the inconvenience!

   I hope there is a way to test the usability of releases prior to making them, somehow, it's not the first time a release breaks even though it looks alright. Maybe something like this can be contributed. Personally I do consider setup.py and friends black magic that I cannot touch or tame, and must be relying on contributions to improve the situation. Thanks for your understanding and support.

   Reacted by Happy Singer
6. Byron

   added

   acknowledged

   on Jul 12, 2020
7. priv-kweihmann commented on Jul 12, 2020

   

   priv-kweihmann

   on Jul 12, 2020

   Contributor

   More actions

   Definitely related to the changes coming from #1028 , could @priv-kweihmann have a look?
   The tar archive definitely has the 'git/objects' directory, so I am a bit surprised it doesn't get installed.

   As immediate action I am rolling the change back.

   I will - as this could take some time, it's really better to rollback for now. Will try to include some tests so that this won't happen again

   Reacted by Happy Singer
8. Byron commented on Jul 13, 2020

   

   Byron

   on Jul 13, 2020

   Member

   More actions

   I am closing this issue as it was fixed with v3.1.5, which was released about 30 minutes after v3.1.4.
   With the PR above we have brought back the reduced package size in v3.1.6, which is likely to be working as we are now testing for git being importable after having been installed (from source).
9. Byron

   closed this as completedon Jul 13, 2020

Issue actions