GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — "make [force_]release" attempts upload even if build fails · Issue #1660 · gitpython-developers/GitPython

"make [force_]release" attempts upload even if build fails #1660

New issue
Copy link
New issue
Copy link
Closed
#1661
Closed
"make [force_]release" attempts upload even if build fails#1660
#1661
Copy link
Labels
acknowledged
Milestone
v3.1.37 - Bugfixes

Description

@EliahKagan
EliahKagan
opened on Sep 13, 2023
Issue body actions

The force_release target in Makefile (which is also used by the release target after it attempts to check some things separate from this issue) had previously stopped after a failed attempt to build. But since #1654 it runs twine to attempt the upload whether or not the build succeeded.

The problem is that a command of the form a || b succeeds when a succeeds, but also when a fails but b succeeds:

GitPython/Makefile

Line 20 in 25597cb

python3 -m build --sdist --wheel || echo "Use a virtual-env with 'python -m venv env && source env/bin/activate' instead"

So that command fails only in the rare case that echo fails to write to standard output.

But the message about how using a virtual environment may remedy a build failure is valuable and should not be removed. Instead, the logic can be adjusted to make sure the command fails if it gets that far.

There are some other improvements I'd like to propose to Makefile, and I think it will be convenient to include a fix for this with them. But I wanted to open an issue for this, because I think this behavior is unexpected and could cause confusion while making a release if it is not anticipated (if the next release is made before it is fixed and something keeps the build command from succeeding).

Activity

  1. Byron
    added
    acknowledged
    on Sep 14, 2023
  2. Byron
    added this to the v3.1.37 - Bugfixes milestone on Sep 14, 2023
  3. Byron
    closed this as completedin #1661on Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    acknowledged

    Type

    No type

    Projects

    No projects

      Milestone

      • v3.1.37 - Bugfixes

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.