GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — in 0.3.2 executing git commands using environment variables breaks · Issue #207 · gitpython-developers/GitPython

in 0.3.2 executing git commands using environment variables breaks #207

New issue
Copy link
New issue
Copy link
Closed
Closed
in 0.3.2 executing git commands using environment variables breaks#207
Copy link
Labels
acknowledged
Milestone
v0.3.3

Description

@electrofelix
electrofelix
opened on Nov 17, 2014
Issue body actions

Recent release 0.3.2 contains a change to set the LC_MESSAGES=C for all git commands to ensure the error messages are consistent across systems. this breaks commands that use the environment to allow users to control behaviour.

To reproduce, clone the GitPython repo, checkout the current 0.3 branch and within execute the following command

PYTHONPATH=. python -c 'import os
import git
test = git.Git(".")
os.environ["GIT_EDITOR"] = "cat"
test.var("GIT_EDITOR")'

Output will be:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "git/cmd.py", line 240, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "git/cmd.py", line 536, in _call_process
    return self.execute(make_call(), **_kwargs)
  File "git/cmd.py", line 399, in execute
    raise GitCommandError(command, status, stderr_value)
git.exc.GitCommandError: 'git var GIT_EDITOR' returned exit status 128: fatal: Terminal is dumb, but EDITOR unset

This breaks https://github.com/stackforge/git-upstream usage of GitPython.

Activity

  1. Byron
    added
    acknowledged
    on Nov 17, 2014
  2. Byron
    added this to the v0.3.3 milestone on Nov 17, 2014
  3. Byron
    closed this as completedin #208on Nov 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    acknowledged

    Type

    No type

    Projects

    No projects

      Milestone

      • v0.3.3

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions
      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.