GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Copy environment for subprocess execution by electrofelix · Pull Request #208 · gitpython-developers/GitPython

Conversation

@electrofelix

@electrofelix electrofelix commented Nov 17, 2014

Copy link
Copy Markdown

fixes #207 by ensuring the os.environ is copied before overriding LC_MESSAGES, in a similar manner to master.

Git utilizes multiple environment variables to control various
behaviours. Make sure to set LC_MESSAGES on a copy of the environment
instead of discarding any variables that may be set by the user or
default shell environment such as EDITOR.

Add test to assert that when overriding GIT_EDITOR via os.environ that
the modified value will be picked up by and git commands called.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Darragh Bailey
Copy environment for subprocess execution
8df6b87 
Git utilizes multiple environment variables to control various
behaviours. Make sure to set LC_MESSAGES on a copy of the environment
instead of discarding any variables that may be set by the user or
default shell environment such as EDITOR.

Add test to assert that when overriding GIT_EDITOR via os.environ that
the modified value will be picked up by and git commands called.
@Byron
Byron merged commit 8df6b87 into gitpython-developers:0.3 Nov 17, 2014
@Byron Byron added this to the v0.3.3 milestone Nov 17, 2014
@Byron

Byron commented Nov 17, 2014

Copy link
Copy Markdown
Member

Thanks a lot ! Sorry for missing this one.
If you don't think waiting for 0.3.3 is going to be suitable for you, I can make an intermediate patch release as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@electrofelix

electrofelix commented Nov 17, 2014

Copy link
Copy Markdown
Author

Alternatively I can issue a point release for git-upstream to ensure the requirements.txt sets "!=0.3.2" for GitPython. Though I wonder if there are other projects impacted by this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron

Byron commented Nov 18, 2014

Copy link
Copy Markdown
Member

Let's not find out ;). I have just pushed a patch release to pypi, which incorporates this fix.
It's 0.3.2.1 .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

v0.3.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@electrofelix @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.