Description

mwatts15

opened on Aug 23, 2018

Issue body actions

I see these imports of unittest in

• GitPython/git/objects/submodule/base.py

  Line 6 in a8591a0

  from unittest import SkipTest

• GitPython/git/util.py

  Line 17 in f3265bd

  from unittest import SkipTest

I generally think that test code should not be built into the business logic. Is there a reason why using a skipIf decorator is insufficient?

Activity

1. Byron

   added

   acknowledged

   on Oct 14, 2018
2. Byron commented on Oct 14, 2018

   

   Byron

   on Oct 14, 2018

   Member

   More actions

   Good catch, I absolutely agree! Even though I am pretty sure there was a very good reason to do that at some point in time. With the current state of windows test, for which these dependencies seemingly have been introduced. Maybe @ankostis can provide more context, who did magnificent work a while ago to get windows back into shape.

   Reacted by Mark Watts
3. EliahKagan

   added a commit that references this issue on Nov 14, 2023

   List all non-passing tests in test summaries

   359116b
4. marioaag

   added a commit that references this issue on Nov 28, 2023

   List all non-passing tests in test summaries

   07f3641
5. EliahKagan

   added 2 commits that reference this issue on Dec 19, 2023

   Run test_env_vars_for_windows_tests only on Windows

   6a8ed70

   Convert constant and attribute comments to docstrings

   94a85d1
6. Byron

   added the

   Task

   issue type on Jul 20, 2026
7. Byron

   closed this as not plannedon Jul 20, 2026

Issue actions