GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixed broken paths in tutorial documentation by kiancross · Pull Request #1033 · gitpython-developers/GitPython

Conversation

@kiancross

@kiancross kiancross commented Jul 13, 2020

Copy link
Copy Markdown
Contributor

PR for #1032
Fix for bug introduced in #1031.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kiancross
Fixed broken file paths.
762d8fb
@kiancross

kiancross commented Jul 13, 2020

Copy link
Copy Markdown
Contributor Author

Warnings should probably be treated as errors when building the documentation (including a non-existent file is a warning not an error). This would then have been caught by the GitHub action which builds the documentation. However, the other superfluous warnings being produced by Sphinx would need to be sorted first.

Byron reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Byron
Byron merged commit a3ea6c0 into gitpython-developers:master Jul 13, 2020
@Byron

Byron commented Jul 13, 2020

Copy link
Copy Markdown
Member

Thanks a lot for helping to fix this one!
So many places where releases can go wrong, and thus far GitPython was just pretty lucky.

I agree, it would be great to have sphinx fail instead of ignoring warnings - and I wonder if one could keep only the warnings that are known to be errors, instead of having to fix all the other warnings, in case that get's us to having at least some test earlier.

On the other hand, maybe now we are stable once again so we are good for the years to come.

It seems like latest is now back, but another release is required to fix stable.
Why not :D.

kiancross reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Byron Byron added this to the v3.1.6 - Bugfixes milestone Jul 13, 2020
@kiancross
kiancross deleted the fix-doc-examples branch July 13, 2020 13:07
@kiancross kiancross mentioned this pull request Jul 13, 2020
Treat warnings as errors when building documentation #1035
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.8 - Bugfixes

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kiancross @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.