GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Treat warnings as errors when building documentation by kiancross · Pull Request #1035 · gitpython-developers/GitPython

Conversation

@kiancross

@kiancross kiancross commented Jul 13, 2020

Copy link
Copy Markdown
Contributor

This fixes all the current warnings when building the documentation and updates the Makefile to treat warnings as errors.

In reference to: #1033

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kiancross
Fixed all warnings in documentation and updated Makefile to treat war…
3a87892 
…nings as errors.
@Byron Byron added this to the v3.1.8 - Bugfixes milestone Jul 13, 2020
@Byron

Byron commented Jul 13, 2020

Copy link
Copy Markdown
Member

You are on fire! Thanks so much!

With this fix there will be no silent breakage of the documentation anymore, and of course, it has gotten a little better as many of these warnings seem like actual errors or mistakes.
kiancross reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron
Byron merged commit 30387f1 into gitpython-developers:master Jul 13, 2020
@kiancross
kiancross deleted the fix-documentation-warnings branch July 13, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.8 - Bugfixes

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kiancross @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.