GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Drop python 3.4, prep for adding types by Yobmod · Pull Request #1188 · gitpython-developers/GitPython

Conversation

@Yobmod

@Yobmod Yobmod commented Feb 28, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Drop python 3.4 in setup.py and tox.ini
  • Update .gitnignore
  • Add mypy.ini
  • Add git/py.typed file and to setup.py
  • add test/testrunner.py as a hook for monkeytype
  • Add git/types.py for type aliases and classes
  • (Some commits just formatting. VSCode switched my flake8 off for mypy)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Yobmod added 7 commits February 28, 2021 17:52
@Yobmod
drop py3.4 support
1f2f3e8
@Yobmod
update .gitignore prior to types
af7913c
@Yobmod
add testrunner.py to run all tests (as hook for static analysis)
9c6178f
@Yobmod
add py.typed, mypy.ini and git/types.py
2d92fee
@Yobmod
move cmd.py types to another branch, mark typing import as unused
b4fe276
@Yobmod
add newline
300261d
@Yobmod
add newlines
26ccee1
@Yobmod

Yobmod commented Feb 28, 2021

Copy link
Copy Markdown
Contributor Author

I've had to rename testrunner.py as it was interferring with the checks. Feel free to change to a better name!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron

Byron commented Mar 2, 2021

Copy link
Copy Markdown
Member

Thanks a lot! Please let me know if this is a draft (and I will make it a draft PR) or when it's ready to be merged as foundation for types (I really don't know much anything about that and rely solely on your expertise, thanks in advance for bearing my ignorance 😅).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yobmod

Yobmod commented Mar 2, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I think this is ready to merge as is.
It doesn't touch any of the existing code (except setup.py), but gets it all ready for adding types, whichever route we end up going for that.
Byron reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron
Byron merged commit 20f4a9d into gitpython-developers:master Mar 3, 2021
@Byron

Byron commented Mar 3, 2021

Copy link
Copy Markdown
Member

Thanks a lot, I am looking forward to seeing the first types :)!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull request Oct 23, 2023
@EliahKagan
Add a module docstring to tstrunner.py
e4a4186 
It benefits from a docstring because it is not referenced in code
or documentation, and its purpose is/was otherwise unclear.

The docstring includes a reference to gitpython-developers#1188 for more information.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull request Oct 23, 2023
@EliahKagan
Add a module docstring to tstrunner.py
627b8b4 
It benefits from a docstring because it is not referenced in code
or documentation, and its purpose is/was otherwise unclear.

The docstring includes a reference to gitpython-developers#1188 for more information.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull request Oct 23, 2023
@EliahKagan
Add a module docstring to tstrunner.py
cf9243a 
It benefits from a docstring because it is not referenced in code
or documentation, and its purpose is/was otherwise unclear.

The docstring includes a reference to gitpython-developers#1188 for more information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Yobmod @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.