GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add more types by Yobmod · Pull Request #1202 · gitpython-developers/GitPython

Conversation

@Yobmod

@Yobmod Yobmod commented Mar 16, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Added types to:

git.init.py,
compat.py,
db.py,
diff.py,
exc.py,
util.py

Passes mypy and pyright checks

Also some suggested fixes from #1192

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Yobmod added 2 commits March 16, 2021 19:16
@Yobmod
rebase on master
9562ae2
@Yobmod
add types to git.__init__, compat, db, diff, exc, util
5232c89
@Yobmod Yobmod mentioned this pull request Mar 16, 2021
Add initial types to repo/fun.py #1192
Merged
Yobmod added 2 commits March 16, 2021 22:48
@Yobmod
fixes from #1202
a728b0a
@Yobmod
chane HEAD typing to SymbolicReference
c93e971
Byron
Byron approved these changes Mar 17, 2021
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks a lot for your perseverance!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Byron
Byron merged commit 6643a9f into gitpython-developers:master Mar 17, 2021
@jmcgill298 jmcgill298 mentioned this pull request Apr 21, 2021
GitCommand errors are stringifying bytes in 3.1.15 #1220
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Yobmod @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.