GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix missing stderr when the progress parameter of _clone is None by liangjingyang · Pull Request #1224 · gitpython-developers/GitPython

Conversation

@liangjingyang

@liangjingyang liangjingyang commented Apr 22, 2021

Copy link
Copy Markdown
Contributor

Try to fix #1221

The to_progress_instance function will convert None to RemoteProgress instance, so the line if progress_checked is True if progress parameter is None.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@liangjingyang
Fix missing stderr when the progress parameter of _clone is None
3b274b8
muggenhor
muggenhor reviewed Apr 22, 2021
View reviewed changes

@muggenhor muggenhor left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this! I've created a unit test that fails without and succeeds with this change (also with only the the condition change as I suggested).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread git/repo/base.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Byron

Byron commented Apr 22, 2021

Copy link
Copy Markdown
Member

Thanks for finding this! I've created a unit test that fails without and succeeds with this change (also with only the the condition change as I suggested).

Are you able to push it into this PR? If not I would be happy to do that for you if you post it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@muggenhor muggenhor mentioned this pull request Apr 22, 2021
test(clone): verify stderr for a failing clone into a non-empty dir #1225
Closed
muggenhor and others added 2 commits April 22, 2021 16:40
@muggenhor @Byron
test(clone): verify stderr for a failing clone into a non-empty dir
4f03eee 
Addresses gitpython-developers#1221, gitpython-developers#1223
@Byron
fix flake
6d0bd1d
@Byron

Byron commented Apr 22, 2021

Copy link
Copy Markdown
Member

Once approved by @muggenhor this one should be ready to merge. Looks good to me (as the tests are green :) even though without the fix they are not).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
muggenhor
muggenhor approved these changes Apr 22, 2021
View reviewed changes
Comment thread git/repo/base.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Byron
Byron merged commit b85fec1 into gitpython-developers:main Apr 22, 2021
@Byron Byron added this to the v3.1.16 - Bugfixes milestone Apr 22, 2021
@Byron Byron mentioned this pull request Apr 22, 2021
[tracking] Unbreaking v3.1.15 (yanked) #1223
Closed
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@muggenhor muggenhor muggenhor approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.16 - Bugfixes

Development

Successfully merging this pull request may close these issues.

GitCommand missing stderr

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@liangjingyang @Byron @muggenhor
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.