GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test(clone): verify stderr for a failing clone into a non-empty dir by muggenhor · Pull Request #1225 · gitpython-developers/GitPython

Conversation

@muggenhor

@muggenhor muggenhor commented Apr 22, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This adds a test case that would have caught #1221. It thus addresses (partially) the concern of "how to prevent breaking things in the future" expressed in #1223. It additionally verifies that the fix in #1224 actually works.

Edit: this should introduce a single failing test case that should be flipped to passing by #1224.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@muggenhor
test(clone): verify stderr for a failing clone into a non-empty dir
b269681 
Addresses #1221, #1223
@Byron

Byron commented Apr 22, 2021

Copy link
Copy Markdown
Member

Thanks a lot for your help!

It's good to see this one fail - thus without #1224 there is an issue.
The commit was pushed into said PR which should remain green.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron Byron closed this Apr 22, 2021
@Byron
fix flake
86c01a2
@Byron Byron reopened this Apr 22, 2021
@muggenhor muggenhor mentioned this pull request Apr 22, 2021
[tracking] Unbreaking v3.1.15 (yanked) #1223
Closed
3 tasks done
@muggenhor

muggenhor commented Apr 23, 2021

Copy link
Copy Markdown
Contributor Author

merged along with #1224
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@muggenhor muggenhor closed this Apr 23, 2021
@muggenhor
muggenhor deleted the test/clone-stderr branch April 23, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@muggenhor @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.