GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Close .git/index file descriptor by skshetry · Pull Request #1394 · gitpython-developers/GitPython

Conversation

@skshetry

@skshetry skshetry commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

The index fd is not closed, which makes it fail on Windows with PermissionError:

E PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_commit_in_root_repo_with_0\\.git\\index'

and sometimes with not much information when using APIs that interact with git binary:

fatal: Unable to write new index file

Also see treeverse/scmrepo#27 and conda-forge/gitpython-feedstock#62.

This regression was introduced on #1391 (specifically on d79d20d, and released on 3.1.25).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skshetry
Close .git/index file descriptor
6a47114
@skshetry
skshetry force-pushed the close-fd branch from bf1f775 to 6a47114 Compare January 10, 2022 10:44
@IRDonch IRDonch mentioned this pull request Jan 10, 2022
Remove hacks that were added to work around issues in pycocotools open-edge-platform/datumaro#449
Merged
7 tasks
@Byron Byron added the acknowledged label Jan 10, 2022
Byron added a commit that referenced this pull request Jan 10, 2022
@Byron
Assure index file descriptor is closed after reader (#1394) (#1395)
e16a004 
A regression that was introduced with d79d20d.
@Byron

Byron commented Jan 10, 2022

Copy link
Copy Markdown
Member

Thanks a lot for the fix. I thought that using try:finally might be even safer and implemented that in e16a004, which is why this PR has to be closed without merging.

A new release will be created within a couple of minutes.
skshetry and zhiltsov-max reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron Byron closed this Jan 10, 2022
@skshetry
skshetry deleted the close-fd branch January 10, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

acknowledged

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@skshetry @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.