GeezerVison is showing github.com — Update OSS-Fuzz Scripts to Use New QA-Assets Repo Structure by DaveLak · Pull Request #1913 · gitpython-developers/GitPython
Conversation
DaveLak
commented
May 8, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
merging gitpython-developers/qa-assets#2 should be coordinated with merging this PR.
This change is required to support the changes to the seed data repo structure introduced in:
gitpython-developers/qa-assets#2
This moves most of the seed data related build steps into the OSS-Fuzz Docker image build via container-environment-bootstrap.sh. This includes moveing the dictionaries into that repo.
The fuzzing/README.md here should be updated in a follow-up with a link to the qa-assets repo (and probably some context setting about corpora in general) but I have opted to defer that as I think the functionality added by the seed data improvements is valuable as is and shouldn't be blocked by documentation writers block.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This change is required to support the changes to the seed data repo
structure introduced in:
gitpython-developers/qa-assets#2
This moves most of the seed data related build steps into the OSS-Fuzz
Docker image build via `container-environment-bootstrap.sh`. This
includes moveing the dictionaries into that repo.
The fuzzing/README.md here should be updated in a follow-up with a link
to the qa-assets repo (and probably some context setting about corpora
in general) but I have opted to defer that as I think the functionality
added by the seed data improvements is valuable as is and shouldn't be
blocked by documentation writers block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for driving fuzzing forward, relentlessly!
I will set this to auto-merge so when done, you could merge the PR in qa-assets yourself.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
DaveLak reacted with thumbs up emoji
Thanks a lot for driving fuzzing forward, relentlessly!
Thanks for letting me! I've still got my eyes on gitoxide fuzzing, so don't worry 😄
I will set this to auto-merge so when done, you could merge the PR in qa-assets yourself.
Thanks! Will do.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
It turns out there is no auto-merging for me, so I will just merge both myself when I get back.
|
DaveLak reacted with heart emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
Byron
Byron approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.