GeezerVison is showing github.com — Restructure Fuzzer Seed Data by DaveLak · Pull Request #2 · gitpython-developers/qa-assets
Conversation
DaveLak
commented
May 8, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Merging this change requires gitpython-developers/GitPython#1913, the corresponding GitPython PR, to be merged at the same time in the GitPython repo to update the OSS-Fuzz scripts to prevent breaking the builds.
The most significant change introduced here is replacing the .zip files containing seed corpora with sub-directories for each fuzz target containing an uncompressed corpus. This change makes it easier to update each corpus on a per-input-blob basis, as well as making the content of each corpus easier to inspect manually.
The inputs added in this commit are taken directly from the corpora backups generated by ClusterFuzz/OSS-Fuzz and can (and should) likely be reduced to their minimal sets in a follow-up PR.
Other changes:
- Renamed the
dict sub-directory to dictionaries for clarity.
- Updated the README to better document what this repository contains. The README could use some improvement as well, including instructions for contributing and generating new inputs, but for now it should be good enough (I hope.) The "Dictionaries" section was migrated from the GitPython fuzzing README.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
**Merging this change requires a corresponding PR to be merged at the same time
in the GitPython repo to update the OSS-Fuzz scripts to prevent breaking the
builds.**
The most significant change introduced here is replacing the `.zip` files
containing seed corpora with sub-directories for each fuzz target containing an
uncompressed corpus. This change makes it easier to update each corpus on a
per-input-blob basis, as well as making the content of each corpus easier to
inspect manually.
The inputs added in this commit are taken directly from the corpora backups
generated by ClusterFuzz/OSS-Fuzz and can (and should) likely be reduced to
their minimal sets in a follow-up PR.
Other changes:
- Renamed the `dict` sub-directory to `dictionaries` for clarity.
- Updated the README to better document what this repository contains. The README
could use some improvement as well, including instructions for contributing and
generating new inputs, but for now it should be good enough (I hope.) The
"Dictionaries" section was migrated from the GitPython fuzzing README.
DaveLak
added a commit
to DaveLak/GitPython
that referenced
this pull request
May 8, 2024
This change is required to support the changes to the seed data repo
structure introduced in:
gitpython-developers/qa-assets#2
This moves most of the seed data related build steps into the OSS-Fuzz
Docker image build via `container-environment-bootstrap.sh`. This
includes moveing the dictionaries into that repo.
The fuzzing/README.md here should be updated in a follow-up with a link
to the qa-assets repo (and probably some context setting about corpora
in general) but I have opted to defer that as I think the functionality
added by the seed data improvements is valuable as is and shouldn't be
blocked by documentation writers block.
Reviewers
Byron
Awaiting requested review from Byron
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.