GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fuzzing: Fix Broken Fuzz Test for Git Submodule Handling by DaveLak · Pull Request #1997 · gitpython-developers/GitPython

Conversation

@DaveLak

@DaveLak DaveLak commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

Hey there 👋

As you may or may not have seen, the fuzz_submodule.py harness has been failing for some time now and I believe it is responisble for the "fuzzing build: failing" status on OSS-Fuzz.

I looked into it and it appears to be an issue with the test implementation, not GitPython.

The changes here should fix the issue causing the failure!

Please see the commit message for additional details.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DaveLak
Fuzzing: Fix broken test for Git submodule handling
7751d0b 
Ensured submodule names, paths, and commit messages are sanitized to
avoid invalid states that are expected to cause exceptions and should
not halt the fuzzer.

In particular, the changes here:
- Sanitized inputs for submodule names, paths, and commit messages.
- Added validation for submodule SHA and path integrity.
Byron
Byron approved these changes Jan 11, 2025
View reviewed changes

@Byron Byron left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your continued support with this, it's much appreciated!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Byron
Byron merged commit 583c011 into gitpython-developers:main Jan 11, 2025
@DaveLak
DaveLak deleted the fuzzing/fuzz-targets/git-broken-fuzz-submodule-test branch January 11, 2025 12:55
@DaveLak

DaveLak commented Jan 12, 2025

Copy link
Copy Markdown
Contributor Author

This worked. Issue now resolved on the OSS-Fuzz tracker: https://issues.oss-fuzz.com/379326001
Byron reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DaveLak @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.