GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Specify explicit `contents: read` workflow permissions by EliahKagan · Pull Request #2033 · gitpython-developers/GitPython

Conversation

@EliahKagan

@EliahKagan EliahKagan commented May 30, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Specify explicit contents: read workflow permissions

Three CI workflows that need only contents: read permissions and no other permissions did not have explicit permissions set, and would therefore be given default permissions configured for the repository, which might be more expansive than the workflows need.

It is recommended to set explicit workflow permissions. This does that, specifying permissions as pythonpackage.yml already did, and closing three actions/missing-workflow-permissions CodeQL alerts (new since #2032 enabled scanning of GHA workflows).


I'll merge this once I verify that all CI checks still pass.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@EliahKagan
EliahKagan marked this pull request as ready for review May 30, 2025 19:44
@EliahKagan
Specify explicit contents: read workflow permissions
a9833d6
Three CI workflows that need only `contents: read` permissions and
no other permissions did not have explicit permissions set, and
would therefore be given default permissions configured for the
repository, which might be more expansive than the workflows need.

It is recommended to set explicit workflow permissions [1]. This
does that, specifying permissions as `pythonpackage.yml` already
did, and closing three `actions/missing-workflow-permissions`
CodeQL alerts (new since gitpython-developers#2032 enabled scanning of GHA workflows).

[1]: https://codeql.github.com/codeql-query-help/actions/actions-missing-workflow-permissions/
@EliahKagan
EliahKagan force-pushed the gha-permissions branch from d670878 to a9833d6 Compare May 30, 2025 19:52
@EliahKagan
EliahKagan merged commit 751cb2d into gitpython-developers:main May 30, 2025
@EliahKagan
EliahKagan deleted the gha-permissions branch May 30, 2025 20:14
EliahKagan added a commit to EliahKagan/gitdb that referenced this pull request May 30, 2025
@EliahKagan
Specify explicit contents: read workflow permissions
cf4e251
This change is analogous to gitpython-developers/GitPython#2033.
See also gitpython-developers/smmap#60.
EliahKagan added a commit to EliahKagan/smmap that referenced this pull request May 30, 2025
@EliahKagan
Specify explicit contents: read workflow permissions
0664fe8
This change is analogous to gitpython-developers/GitPython#2033.
See also gitpython-developers/gitdb#121.
This was referenced May 30, 2025
Specify explicit contents: read workflow permissions gitpython-developers/gitdb#121
Merged
Specify explicit contents: read workflow permissions gitpython-developers/smmap#60
Merged
EliahKagan added a commit to EliahKagan/gitdb that referenced this pull request May 30, 2025
@EliahKagan
Specify explicit contents: read workflow permissions
d7a7b3b
This change is analogous to gitpython-developers/GitPython#2033.
See also gitpython-developers/smmap#60.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@EliahKagan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.