GeezerVison

Copy link

Copy Markdown

Contributor

George-Ogden marked this pull request as ready for review November 28, 2025 12:24

Byron requested a review from Copilot November 29, 2025 09:46

Copilot started reviewing on behalf of Byron November 29, 2025 09:46

View session

Copilot finished reviewing on behalf of Byron November 29, 2025 09:49

Copilot AI reviewed Nov 29, 2025

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Byron reviewed Nov 29, 2025

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Byron approved these changes Nov 29, 2025

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

27 checks passed

The `Check types with mypy` step in the `test` job of
`pythonpackage.yml` ran only `if: matrix.python-version != '3.8'`.
That condition was added in gitpython-developers#2087, alongside a `python_version >= "3.9"`
marker on mypy in `test-requirements.txt`. Since mypy was not
installed on older Pythons, the step had to be skipped there. (The
same pull request also pinned mypy to 1.18.2, which itself requires
Python 3.9 or later.) The condition originally excluded 3.7 as well,
and that part was removed along with 3.7 support.

Since Python 3.8 through 3.10 were moved out of the `test` job's
matrix into the `install/import` job, which does not run mypy, the
`test` job runs only on 3.11 through 3.15t. No row of its matrix, and
no `include` entry, uses 3.8, so the condition is always true. It
suggested that the job still covers 3.8 and did nothing else.

Remove it. The step runs in exactly the same jobs as before.

The `python_version >= "3.9"` marker on the mypy requirement is left
as it is. It is packaging metadata for the `test` extra, not CI
configuration.

`actionlint` reports no problems, and zizmor 1.31.1 at the `pedantic`
level reports no new findings.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

Now that tox also runs in the weekly `tox` workflow, this matters
more: as things were, that workflow could not fail because of the
`mypy` environment, even if the environment could not be set up at
all.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

The `mypy` environment passed, with `ignore_outcome` false, on each of
Python 3.9.6, 3.10.22, and 3.13.17, selected with
`-x tool.tox.env.mypy.base_python=py39` and so on ("Success: no
issues found in 40 source files"). 3.9 and 3.10 are in its
`base_python` list, though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

Now that tox also runs in the weekly `tox` workflow, this matters
more: as things were, that workflow could not fail because of the
`mypy` environment, even if the environment could not be set up at
all.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

The `mypy` environment passed, with `ignore_outcome` false, on each of
Python 3.9.6, 3.10.22, and 3.13.17, selected with
`-x tool.tox.env.mypy.base_python=py39` and so on ("Success: no
issues found in 40 source files"). 3.9 and 3.10 are in its
`base_python` list, though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

Now that tox also runs in the weekly `tox` workflow, this matters
more: as things were, that workflow could not fail because of the
`mypy` environment, even if the environment could not be set up at
all.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

The `mypy` environment passed, with `ignore_outcome` false, on each of
Python 3.9.6, 3.10.22, and 3.13.17, selected with
`-x tool.tox.env.mypy.base_python=py39` and so on ("Success: no
issues found in 40 source files"). 3.9 and 3.10 are in its
`base_python` list, though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

Now that tox also runs in the weekly `tox` workflow, this matters
more: as things were, that workflow could not fail because of the
`mypy` environment, even if the environment could not be set up at
all.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

The `mypy` environment passed, with `ignore_outcome` false, on each of
Python 3.9.6, 3.10.22, and 3.13.17, selected with
`-x tool.tox.env.mypy.base_python=py39` and so on ("Success: no
issues found in 40 source files"). 3.9 and 3.10 are in its
`base_python` list, though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

Now that tox also runs in the weekly `tox` workflow, this matters
more: as things were, that workflow could not fail because of the
`mypy` environment, even if the environment could not be set up at
all. In a minimal project with tox 4.22.0 and 4.67.1, an environment
with `ignore_outcome = true` and a dependency that cannot be installed
let tox exit with status 0; without `ignore_outcome`, the same
environment made tox exit with status 1.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

The `mypy` environment passed, with `ignore_outcome` false, on each of
Python 3.9.6, 3.10.22, and 3.13.17, selected with
`-x tool.tox.env.mypy.base_python=py39` and so on ("Success: no
issues found in 40 source files"). 3.9 and 3.10 are in its
`base_python` list, though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

Now that tox also runs in the weekly `tox` workflow, this matters
more: as things were, that workflow could not fail because of the
`mypy` environment, even if the environment could not be set up at
all. In a minimal project with tox 4.22.0 and 4.67.1, an environment
with `ignore_outcome = true` and a dependency that cannot be installed
let tox exit with status 0; without `ignore_outcome`, the same
environment made tox exit with status 1.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

The `mypy` environment passed, with `ignore_outcome` false, on each of
Python 3.9.6, 3.10.22, and 3.13.17, selected with
`-x tool.tox.env.mypy.base_python=py39` and so on ("Success: no issues
found in 40 source files"). 3.9 and 3.10 are in its `base_python` list,
though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

Now that tox also runs in the weekly `tox` workflow, this matters
more: as things were, that workflow could not fail because of the
`mypy` environment, even if the environment could not be set up at
all. In a minimal project with tox 4.22.0 and 4.67.1, an environment
with `ignore_outcome = true` and a dependency that cannot be installed
let tox exit with status 0; without `ignore_outcome`, the same
environment made tox exit with status 1.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

The `mypy` environment passed, with `ignore_outcome` false, on each of
Python 3.9.6, 3.10.22, and 3.13.17, selected with
`-x tool.tox.env.mypy.base_python=py39` and so on ("Success: no issues
found in 40 source files"). 3.9 and 3.10 are in its `base_python` list,
though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

Now that tox also runs in the weekly `tox` workflow, this matters
more: as things were, that workflow could not fail because of the
`mypy` environment, even if the environment could not be set up at
all. In a minimal project with tox 4.22.0 and 4.67.1, an environment
with `ignore_outcome = true` and a dependency that cannot be installed
let tox exit with status 0; without `ignore_outcome`, the same
environment made tox exit with status 1.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

The `mypy` environment passed, with `ignore_outcome` false, on each of
Python 3.9.6, 3.10.22, and 3.13.17, selected with
`-x tool.tox.env.mypy.base_python=py39` and so on ("Success: no issues
found in 40 source files"). 3.9 and 3.10 are in its `base_python` list,
though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

Now that tox also runs in the weekly `tox` workflow, this matters
more: as things were, that workflow could not fail because of the
`mypy` environment, even if the environment could not be set up at
all. In a minimal project with tox 4.22.0 and 4.67.1, an environment
with `ignore_outcome = true` and a dependency that cannot be installed
let tox exit with status 0; without `ignore_outcome`, the same
environment made tox exit with status 1.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

The `mypy` environment passed, with `ignore_outcome` false, on each of
Python 3.9.6, 3.10.22, and 3.13.17, selected with
`-x tool.tox.env.mypy.base_python=py39` and so on ("Success: no issues
found in 40 source files"). 3.9 and 3.10 are in its `base_python` list,
though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

Now that tox also runs in the weekly `tox` workflow, this matters
more: as things were, that workflow could not fail because of the
`mypy` environment, even if the environment could not be set up at
all. In a minimal project with tox 4.22.0 and 4.67.1, an environment
with `ignore_outcome = true` and a dependency that cannot be installed
let tox exit with status 0; without `ignore_outcome`, the same
environment made tox exit with status 1.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

The `mypy` environment passed, with `ignore_outcome` false, on each of
Python 3.9.6, 3.10.22, and 3.13.17, selected with
`-x tool.tox.env.mypy.base_python=py39` and so on ("Success: no issues
found in 40 source files"). 3.9 and 3.10 are in its `base_python` list,
though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

Now that tox also runs in the weekly `tox` workflow, this matters
more: as things were, that workflow could not fail because of the
`mypy` environment, even if the environment could not be set up at
all. In a minimal project with tox 4.22.0 and 4.67.1, an environment
with `ignore_outcome = true` and a dependency that cannot be installed
let tox exit with status 0; without `ignore_outcome`, the same
environment made tox exit with status 1.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

The `mypy` environment passed, with `ignore_outcome` false, on each of
Python 3.9.6, 3.10.22, and 3.13.17, selected with
`-x tool.tox.env.mypy.base_python=py39` and so on ("Success: no issues
found in 40 source files"). 3.9 and 3.10 are in its `base_python` list,
though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

`ignore_outcome` also hides failures to set the environment up at
all. In a minimal project with tox 4.22.0 and 4.67.1, an environment
with `ignore_outcome = true` and a dependency that cannot be installed
let tox exit with status 0; without `ignore_outcome`, the same
environment made tox exit with status 1.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

With tox 4.67.1, the `mypy` environment now passes on Python 3.9.6
and 3.13.18, selected with `-x testenv:mypy.base_python=py39` and
`py313` ("Success: no issues found in 40 source files"). 3.9 is in its
`base_python` list, though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

`ignore_outcome` also hides failures to set the environment up at
all. In a minimal project with tox 4.22.0 and 4.67.1, an environment
with `ignore_outcome = true` and a dependency that cannot be installed
let tox exit with status 0; without `ignore_outcome`, the same
environment made tox exit with status 1.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

With tox 4.67.1, the `mypy` environment now passes on Python 3.9.6
and 3.13.18, selected with `-x testenv:mypy.base_python=py39` and
`py313` ("Success: no issues found in 40 source files"). 3.9 is in its
`base_python` list, though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

`ignore_outcome` also hides failures to set the environment up at
all. In a minimal project with tox 4.22.0 and 4.67.1, an environment
with `ignore_outcome = true` and a dependency that cannot be installed
let tox exit with status 0; without `ignore_outcome`, the same
environment made tox exit with status 1.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

With tox 4.67.1, the `mypy` environment now passes on Python 3.9.6
and 3.13.18, selected with `-x testenv:mypy.base_python=py39` and
`py313` ("Success: no issues found in 40 source files"). 3.9 is in its
`base_python` list, though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

`ignore_outcome` also hides failures to set the environment up at
all. In a minimal project with tox 4.22.0 and 4.67.1, an environment
with `ignore_outcome = true` and a dependency that cannot be installed
let tox exit with status 0; without `ignore_outcome`, the same
environment made tox exit with status 1.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

With tox 4.67.1, the `mypy` environment now passes on Python 3.9.6
and 3.13.18, selected with `-x testenv:mypy.base_python=py39` and
`py313` ("Success: no issues found in 40 source files"). 3.9 is in its
`base_python` list, though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

`ignore_outcome` also hides failures to set the environment up at
all. In a minimal project with tox 4.22.0 and 4.67.1, an environment
with `ignore_outcome = true` and a dependency that cannot be installed
let tox exit with status 0; without `ignore_outcome`, the same
environment made tox exit with status 1.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

With tox 4.67.1, the `mypy` environment now passes on Python 3.9.6
and 3.13.18, selected with `-x testenv:mypy.base_python=py39` and
`py313` ("Success: no issues found in 40 source files"). 3.9 is in its
`base_python` list, though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>

The tox `mypy` environment has `ignore_outcome = true`, so a failure
there is reported but does not fail the run. 4bea7cf (gitpython-developers#1667) added
that to match CI, where the mypy step had `continue-on-error: true`
because GitPython was not expected to pass mypy at the time. But
50762f1 (gitpython-developers#2087) removed `continue-on-error` from that step, so a mypy
failure has failed CI since then, and mypy passes there on every
Python version the `test` job covers. The tox environment was never
updated to match.

`ignore_outcome` also hides failures to set the environment up at
all. In a minimal project with tox 4.22.0 and 4.67.1, an environment
with `ignore_outcome = true` and a dependency that cannot be installed
let tox exit with status 0; without `ignore_outcome`, the same
environment made tox exit with status 1.

Remove `ignore_outcome`, so `mypy` failures fail tox as they fail CI.

With tox 4.67.1, the `mypy` environment now passes on Python 3.9.6
and 3.13.18, selected with `-x testenv:mypy.base_python=py39` and
`py313` ("Success: no issues found in 40 source files"). 3.9 is in its
`base_python` list, though CI only type-checks on 3.11 and later.

Co-authored-by: Claude Opus 5.5 <[email protected]>