GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: add network marker to tests requiring network access by mcepl · Pull Request #2337 · gitpython-developers/GitPython

Conversation

@mcepl

@mcepl mcepl commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Sometimes it’s useful to have the tests that use the network marked so they can be skipped easily when we know the network is not available.

This is useful for example on SUSE and openSUSE’s build servers. When building our packages the network is disabled so we can assure reproducible builds (among other benefits). With this mark, it’s easier to skip tests that can not succeed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mcepl
feat: add network marker to tests requiring network access
2524e95
Copilot AI balanced review requested due to automatic review settings November 3, 2026 23:47
Copilot started reviewing on behalf of mcepl November 3, 2026 23:49
View session
Copilot AI reviewed Nov 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The net marker leaves socket-dependent tests and a daemon-launching parameter unmarked, so pytest -m 'not net' still attempts network access on socket-restricted builders.

1 open issue
  • Medium severity Mark all loopback-dependent tests with the net marker · New
What changed in this PR

GitHub Copilot: This PR adds a pytest net marker so builders with networking disabled can exclude marked tests using pytest -m 'not net'.

Changes:

  • Registers net as a supported pytest marker.
  • Marks three tests that use the remote-repository daemon helper.
File Description
test/​test_remote.py Marks two remote-operation tests as network-dependent.
test/​test_base.py Imports pytest and marks the remote-repository helper test.
pyproject.toml Registers and describes the net marker.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread pyproject.toml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Byron

Byron commented Nov 4, 2026

Copy link
Copy Markdown
Member

Sure, why not.

It's a bit strange that GitPython needs external network access, and I am looking into this.
From what I can tell right now, plenty of annotations are missing, so it's strange this subset works for you. Maybe there is more about it.

Will have to supersede the PR as I can't push into it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron Byron mentioned this pull request Nov 4, 2026
no network #2338
Merged
@Byron

Byron commented Nov 4, 2026

Copy link
Copy Markdown
Member

Superseded by #2338 (which includes this commit)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron Byron closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron left review comments
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mcepl @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.