GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — no network by Byron · Pull Request #2338 · gitpython-developers/GitPython

Conversation

@Byron

@Byron Byron commented Nov 4, 2026

Copy link
Copy Markdown
Member

Supersedes #2337

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mcepl and others added 2 commits November 4, 2026 00:44
@mcepl
feat: add network marker to tests requiring network access
2524e95
@Byron @codex
test: mark network-dependent tests for restricted builders
cb10d13 
<!-- aent -->
SUSE and openSUSE package builders disable network access for reproducible
builds. Allow them to exclude network-using tests with
`pytest -m 'not net'` while retaining local filesystem tests.

Register `net` in `pyproject.toml` and document in `CONTRIBUTING.md`
that it includes loopback sockets and fixture-triggered package downloads,
not just internet access. Mark the daemon-based repository tests, stalled
remote timeout cases, daemon restart test, installation test, and the
already-skipped external clone test. Mark only the daemon-launching
cleanup parameter so the other cleanup cases remain selected.

Existing skips and test bodies remain unchanged. Normalize TOML formatting
and imports in the touched files.

Assisted-by: GPT 6.0 Astra
Co-authored-by: GPT 6.0 Astra <[email protected]>
Copilot AI balanced review requested due to automatic review settings November 4, 2026 06:58
@Byron Byron mentioned this pull request Nov 4, 2026
feat: add network marker to tests requiring network access #2337
Closed
Copilot started reviewing on behalf of Byron November 4, 2026 07:03
View session
Copilot AI reviewed Nov 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the network-test marking and offline test-selection changes.

No open issues 🎉

What changed in this PR

This PR supports running GitPython’s tests on network-restricted builders, continuing the work in #2337 by identifying tests that require internet access or local sockets.

Changes:

  • Registers pytest.mark.net and documents exclusion with pytest -m 'not net'.
  • Marks network-dependent tests, including only the relevant parameterized cleanup case.
  • Tidies imports and TOML formatting.
File Description
test/​test_remote.py Marks remote-operation and timeout tests that use network sockets.
test/​test_installation.py Marks the installation test that downloads dependencies.
test/​test_clone.py Marks an already-skipped network clone test.
test/​test_cleanup.py Marks daemon cleanup tests and the network-dependent decorator parameter.
test/​test_base.py Marks the remote-repository fixture test.
pyproject.toml Registers the net marker and normalizes formatting.
CONTRIBUTING.md Documents marker usage, loopback coverage, and offline test selection.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Byron
Byron merged commit 8e919a4 into main Nov 4, 2026
68 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Byron @mcepl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.