GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||
GeezerVison is showing github.com — Adding setup for git executable by kenodegard · Pull Request #640 · gitpython-developers/GitPython Conversation
Contributor
Added a convenience function called The first is that now the user can dynamically set the git path AFTER importing GitPython. In the following example git is neither on the user's $PATH nor is $GIT_PYTHON_GIT_EXECUTABLE defined: The second is that this also means that the git executable can be dynamically refreshed at any time by simply calling
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsAdded one function (setup) and an alias (refresh simply calls setup). These functions give the developer one more way to configure the git executable path. This also allows the user to interactively adjust the git executable configured during runtime as these functions dynamically update the executable path for the entire git module. Discovered that the remote module also relies on the git executable as such it also needs to be “refreshed” anytime the git executable is updated or changed. This was best solved by moving the setup function into the top level __init__ where the setup simply calls git.cmd.Git.refresh and git.remote.FetchInfo.refresh. Renamed to simplify and avoid issue with nose tests trying to use `setup` as a setup for testing. Unittest implements basic test for refreshing with a bad git path versus a good git path. Added my name to list. Added the ability to silence the first refresh warning upon import by setting an environment variable.
|
There was an error while loading. Please reload this page.
Codecov Report
@@ Coverage Diff @@ ## master #640 +/- ## ========================================= Coverage ? 92.65% ========================================= Files ? 61 Lines ? 10029 Branches ? 0 ========================================= Hits ? 9292 Misses ? 737 Partials ? 0
Continue to review full report at Codecov.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Renamed GIT_PYTHON_NOWARN to GIT_PYTHON_INITERR and added values for quiet import, warning import, and raise import. These respectively mean that no message or error is printed if git is non-existent, a plain warning is printed but the import succeeds, and an ImportError exception is raised.
Removed few remaining references to git.setup function (as it was renamed to refresh).
Renamed and cleaned up variable names.
Added additional information in the import warning/error that tells the user how to silence the warning/error. Also added a GIT_OK variable that allows for a quick check whether the refresh has succeeded instead of needing to test an actual git command.
|
@Byron what else would you need from me for this to be considered? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Added tilde expansion as part of the refresh function. Added python version check such that we properly capture PermissionError in Python >=3 and OSError in Python <3.
|
Thanks a ton for your contribution, and my apologies for getting to this PR that late! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…etup_for_git_executable Adding setup for git executable
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.