GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — BF: remove ddt from requirements.txt since no ddt required at run time. by yarikoptic · Pull Request #911 · gitpython-developers/GitPython

Conversation

@yarikoptic

@yarikoptic yarikoptic commented Aug 21, 2019

Copy link
Copy Markdown
Contributor

Otherwise, since requirements.txt is loaded into install_requires, any installation
which manages to miss installing ddt could cause setuptools to freak out.
E.g.

here is a traceback from running tests of datalad

======================================================================
ERROR: datalad.metadata.tests.test_aggregation.test_update_strategy
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/datalad/metadata/metadata.py", line 511, in _get_metadata
    extractor_cls = extractors[mtype_key].load()
  File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2442, in load
    self.require(*args, **kwargs)
  File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2465, in require
    items = working_set.resolve(reqs, env, installer, extras=self.extras)
  File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 786, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The "ddt>=1.1.1" distribution was not found and is required by GitPython

in conda environment. Original commit 74a0507
which added ddt there unfortunately does not state the reason so probably was
just a slip

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@yarikoptic
BF: remove ddt from requirements.txt since no ddt required at run time.
5e819da
Otherwise, since requirements.txt is loaded into install_requires, any installation
which manages to miss installing ddt could cause setuptools to freak out.
E.g.

here is a traceback from running tests of datalad

    ======================================================================
    ERROR: datalad.metadata.tests.test_aggregation.test_update_strategy
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/datalad/metadata/metadata.py", line 511, in _get_metadata
        extractor_cls = extractors[mtype_key].load()
      File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2442, in load
        self.require(*args, **kwargs)
      File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2465, in require
        items = working_set.resolve(reqs, env, installer, extras=self.extras)
      File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 786, in resolve
        raise DistributionNotFound(req, requirers)
    pkg_resources.DistributionNotFound: The "ddt>=1.1.1" distribution was not found and is required by GitPython

in conda environment.  Original commit 74a0507
which added ddt there unfortunately does not state the reason so probably was
just a slip
@yarikoptic yarikoptic mentioned this pull request Aug 21, 2019
add ddt test dependency (seems required for test suite to pass with current git-annex) conda-forge/datalad-feedstock#17
Closed
4 of 5 tasks
@Byron Byron modified the milestones: v3.0.1 - Bugfixes, v3.0.2 - Bugfixes Aug 21, 2019
@Byron
Byron merged commit df5c941 into gitpython-developers:master Aug 21, 2019
@Byron

Byron commented Aug 21, 2019

Copy link
Copy Markdown
Member

Thanks a lot! Should I cut a release?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@yarikoptic

yarikoptic commented Aug 22, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

If not too much trouble - it would be great! Thanks in advance!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Byron

Byron commented Aug 22, 2019

Copy link
Copy Markdown
Member

Done, see v3.0.2 .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Harmon758 Harmon758 mentioned this pull request Feb 7, 2020
Remove Python 2 compatibility shims #979
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

v3.0.2 - Bugfixes

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@yarikoptic @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.