GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Test Python 3.7 on Ubuntu 22.04, and add Ubuntu 3.13 by EliahKagan · Pull Request #58 · gitpython-developers/smmap

This repository was archived by the owner on Jul 26, 2026. It is now read-only.

Conversation

@EliahKagan

@EliahKagan EliahKagan commented Jan 2, 2025

Copy link
Copy Markdown
Member

This is analogous to the gitdb test workflow and setup.py updates in gitpython-developers/gitdb#114.

  1. Testing 3.7 on 22.04 rather than 24.04 should fix the problem where it fails because Python 3.7 is not available.
  2. Adding Ubuntu 3.13 to CI may help reveal if there are 3.13-specific problems with smmap.
  3. smmap seems to be working on Python 3.13 (which is a stable Python release) and there are no specific expected problems with it, so this adds it to the list of supported releases.

In particular, this change, due to (1), fixes the current CI failure for smmap observed in f31bfa3.

It looks like changes along the lines of (1), in addition to some other changes, will need to be made in GitPython in order to fix some recent breakages in its CI.

This relates to the CI breakages noted in the comment posted on gitpython-developers/GitPython@e51bf80.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EliahKagan
Test Python 3.7 on Ubuntu 22.04, and add Ubuntu 3.13
636b3e0 
This is analogous to the gitdb test workflow and `setup.py` updates
in gitpython-developers/gitdb#114.

1. Testing 3.7 on 22.04 rather than 24.04 should fix the problem
   where it fails because Python 3.7 is not available.

2. Adding Ubuntu 3.13 to CI may help reveal if there are
   3.13-specific problems with smmap.

3. smmap seems to be working on Python 3.13 (which is a stable
   Python release) and there are no specific expected problems with
   it, so this adds it to the list of supported releases.

In particular, this change, due to (1), fixes the current CI
failure for smmap observed in f31bfa3.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull request Jan 2, 2025
@EliahKagan
Special-case Python 3.7 for OSes we can install it on
9429be6 
This is analogous to the 3.7-related CI change in gitdb that was
part of gitpython-developers/gitdb#114, as
to part of gitpython-developers/smmap#58.

Since some tests are not yet passing on 3.13, this does not add
3.13 to CI, nor to the documentation of supported versions in
`setup.py`. Note that the list there is not enforced; GitPython can
already be installed on Python 3.13 and probably *mostly* works.

(See gitpython-developers#1955
for details on other changes that should be made to fully support
running GitPython on Python 3.13.)
Byron
Byron approved these changes Jan 2, 2025
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your help with this!

I will see to applying similar changes to GitPython as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Byron
Byron merged commit 8d0e0bd into gitpython-developers:master Jan 2, 2025
@EliahKagan

EliahKagan commented Jan 2, 2025

Copy link
Copy Markdown
Member Author

I will see to applying similar changes to GitPython as well.

I'll open a PR in GitPython shortly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@EliahKagan
EliahKagan deleted the versions branch January 2, 2025 11:41
@Byron

Byron commented Jan 2, 2025

Copy link
Copy Markdown
Member

Ah, great, much appreciated. I just took a quick look and it's different enough to make it far less trivial than I had hoped 😅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@EliahKagan EliahKagan mentioned this pull request Jan 2, 2025
Fix various version-related CI breakages gitpython-developers/GitPython#1987
Merged
@EliahKagan

EliahKagan commented Jan 2, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

No problem! I've just opened gitpython-developers/GitPython#1987 for this.

Edit: Fixed link.
Byron reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@Byron Byron Byron approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@EliahKagan @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.