GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow component comparisons without skip_keys by codewithfourtix · Pull Request #300 · google-deepmind/concordia

Conversation

@codewithfourtix

@codewithfourtix codewithfourtix commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

deep_compare_components() defaults skip_keys to None but immediately checks membership in it, raising TypeError. Guard the optional set before checking membership.

Adds tests for nested comparisons with the default arguments, mismatches, and explicit skipped keys.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codewithfourtix
Allow component comparisons without skip_keys
dcffa53 
Signed-off-by: Ali Zulfiqar <[email protected]>
@ajitashwath ajitashwath mentioned this pull request Sep 17, 2026
deep_compare_components crashes when skip_keys is omitted #375
Open
jzleibo
jzleibo previously approved these changes Sep 25, 2026
View reviewed changes
@codewithfourtix
Merge remote-tracking branch 'upstream/main' into fix-component-compa…
7d96591 
…rison-default-skip-keys

# Conflicts:
#	concordia/utils/helper_functions_test.py
@codewithfourtix
codewithfourtix dismissed jzleibo’s stale review via 7d96591 September 28, 2026 07:51
copybara-service Bot pushed a commit that referenced this pull request Sep 28, 2026
@copybara-github
Merge pull request #300 from codewithfourtix:fix-component-comparison…
222d3a4 
…-default-skip-keys

PiperOrigin-RevId: 989678560
Change-Id: I9a88e393352121551833a3cb493d8ac5810543fe
@jzleibo

jzleibo commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

Thank you for the contribution, @codewithfourtix! This change has been merged into main via Copybara in commit 222d3a4 (with full author attribution). Closing this PR now that the change is on main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jzleibo jzleibo closed this Sep 28, 2026
@ajitashwath ajitashwath mentioned this pull request Oct 2, 2026
find_data_in_nested_structure silently drops tuples despite Sequence annotation #387
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzleibo jzleibo jzleibo left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@codewithfourtix @jzleibo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.