GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — make NodeTraverser public and improves it with preOder/postOrder methods by andimarek · Pull Request #1097 · graphql-java/graphql-java

Conversation

@andimarek

@andimarek andimarek commented Jun 23, 2018

Copy link
Copy Markdown
Member

graphql-java should provide a good way to traverse a Document/Query. This makes the NodeTraverser public and adds special pre/post Order methods for easy usage.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andimarek
andimarek requested a review from bbakerman June 23, 2018 09:29
@andimarek

andimarek commented Jun 23, 2018

Copy link
Copy Markdown
Member Author

This includes making some parts of the general Traverser public, but not everything.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andimarek andimarek mentioned this pull request Jun 23, 2018
Add visitor for types and use generic traversal #1084
Merged
@andimarek

andimarek commented Jun 23, 2018

Copy link
Copy Markdown
Member Author

@bbakerman @gkesler @exbe I would like to link to some good explanation about general traversal and for example pre/post order is a special case of depthFirst. Any recommendations? thx
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman approved these changes Jun 24, 2018
View reviewed changes

@bbakerman bbakerman left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - nothing stands out as a problem

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bbakerman bbakerman added this to the 10.0 milestone Jun 25, 2018
@exbe

exbe commented Jun 25, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@andimarek Are you looking for an example, explanation or something else?

Updated: I think it make sense to add similar special cases for breadthFirst too as a legitimate api.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
andimarek added 2 commits June 27, 2018 12:40
@andimarek
make NodeTraverser public and improves it with preOder/postOrder methods
97c9e2a
@andimarek
make public/document
359880d
@andimarek
andimarek force-pushed the node-traverser branch from 0fa461d to 359880d Compare June 27, 2018 19:56
@andimarek
andimarek merged commit 795c232 into master Jul 4, 2018
@andimarek
andimarek deleted the node-traverser branch July 12, 2018 11:27
exbe pushed a commit to intuit/graphql-java that referenced this pull request Jul 27, 2018
amatiushkin amatiushkin
Make TypeTraverser public with respect to graphql-java#1097
126f3df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbakerman bbakerman bbakerman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

9.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@andimarek @exbe @bbakerman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.