GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — 1181 Fix null element in InputValueDefinition#getChildren by tsroka · Pull Request #1182 · graphql-java/graphql-java

Conversation

@tsroka

@tsroka tsroka commented Aug 21, 2018

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Tomek Sroka
1181 Fix null element in InputValueDefinition#getChildren
586964d
johnliucn925
johnliucn925 approved these changes Aug 21, 2018
View reviewed changes
@andimarek

andimarek commented Aug 21, 2018

Copy link
Copy Markdown
Member

@tsroka how did you come across this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andimarek

andimarek commented Aug 21, 2018

Copy link
Copy Markdown
Member

@tsroka could u use the graphql-java formatter (https://github.com/graphql-java/graphql-java/blob/master/graphql-java-code-style.xml) to avoid not needed changes? thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tsroka

tsroka commented Aug 21, 2018

Copy link
Copy Markdown
Author

@andimarek while working on nadel, i needed to traverse AST using NodeTraverser and got NPE. Will fix formatting,
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Tomek Sroka
1181 Fix null element in InputValueDefinition#getChildren
c80341b
@andimarek

andimarek commented Aug 23, 2018

Copy link
Copy Markdown
Member

this should also go into stable 9.x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andimarek andimarek added this to the 10.0 milestone Aug 23, 2018
@andimarek
andimarek merged commit 141b8e4 into graphql-java:master Aug 23, 2018
@andimarek andimarek added the stable fix label Aug 30, 2018
@bbakerman bbakerman added the needs to be backported a bugfix that still needs to be backported label Aug 30, 2018
bbakerman added a commit to bbakerman/graphql-java that referenced this pull request Aug 30, 2018
@bbakerman
backport of graphql-java#1182
dd7d7dc
@bbakerman bbakerman mentioned this pull request Aug 30, 2018
Stable fix of pr 1182 #1194
Merged
bbakerman added a commit that referenced this pull request Aug 30, 2018
@bbakerman
backport of #1182
0b5f286
@andimarek andimarek removed the needs to be backported a bugfix that still needs to be backported label Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@johnliucn925 johnliucn925 johnliucn925 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

10.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tsroka @andimarek @johnliucn925 @bbakerman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.