GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable DataLoader chaining (nesting) by andimarek · Pull Request #3872 · graphql-java/graphql-java

Conversation

@andimarek

@andimarek andimarek commented Mar 30, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

enabling scheduling of nested/chained DataLoader calls

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andimarek
introducing of a special CompletableFuture enabling scheduling of nes…
0a27e76 
…ted/chained DataLoader calls
@andimarek andimarek changed the title introducing of a special CompletableFuture Enable DataLoader nesting/chaining Mar 30, 2025
@github-actions

github-actions Bot commented Mar 30, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Test Results

  315 files    315 suites   2m 26s ⏱️
3 647 tests 3 642 ✅ 5 💤 0 ❌
3 736 runs  3 731 ✅ 5 💤 0 ❌

Results for commit c9a3ff3.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed Mar 30, 2025
View reviewed changes
Comment thread src/main/java/graphql/execution/instrumentation/dataloader/DataLoaderCF.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed Mar 30, 2025
View reviewed changes
Comment thread src/main/java/graphql/execution/instrumentation/dataloader/DataLoaderCF.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed Mar 30, 2025
View reviewed changes
Comment thread src/main/java/graphql/execution/instrumentation/dataloader/DataLoaderCF.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed Mar 30, 2025
View reviewed changes
Comment thread ...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed Mar 30, 2025
View reviewed changes
Comment thread ...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed Mar 30, 2025
View reviewed changes
Comment thread ...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed Mar 30, 2025
View reviewed changes
Comment thread src/test/groovy/graphql/DataLoaderCFTest.groovy Resolved

Uh oh!

There was an error while loading. Please reload this page.
@andimarek
replace countdown latch with an async solution
f655893
@andimarek andimarek mentioned this pull request Mar 30, 2025
JS like Batching #3873
Closed
@andimarek
wip
3675d8a
@dondonz dondonz added this to the 23.1 non-breaking changes and bugfixes milestone Mar 31, 2025
andimarek added 5 commits March 31, 2025 11:37
@andimarek
refactor
c2d0676
@andimarek
refactor
36b2d64
@andimarek
naming
eb8f9bb
@andimarek
comment
d1df820
@andimarek
fix test
2c5da50
Hc747
Hc747 reviewed Apr 1, 2025
View reviewed changes
Comment thread ...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Hc747
Hc747 reviewed Apr 1, 2025
View reviewed changes
Comment thread src/main/java/graphql/schema/DataFetchingEnvironmentImpl.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
andimarek added 9 commits April 1, 2025 15:56
@andimarek
green tests without any chain
62325eb
@andimarek
cleanup
89f2c48
@andimarek
use ResultPath to identify a field instead DFE
67df3a9
@andimarek
fix a bug in the PerLevel dispatcher regarding which level to dispatch
dc8ac9a
@andimarek
fix test
3be8443
@andimarek
don't put ExecutionStrategy into context
0686385
@andimarek
introduce toInternal method in DFE
bcfeff8
@andimarek
Merge branch 'master' into dataloader-cfs
bf0b730
@andimarek
use new DataLoaderDelegate
89b8c13
andimarek added 4 commits April 15, 2025 14:55
@andimarek
fix merge problem
47300cb
@andimarek
Merge branch 'master' into dataloader-cfs
fed7456
@andimarek
naming
d57d4fd
@andimarek
add helper methods to configure new dispatching strategy
34bc3d7
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
Comment thread src/jmh/java/performance/DataLoaderPerformance.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
Comment thread src/main/java/graphql/execution/DataLoaderDispatchStrategy.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
Comment thread src/main/java/graphql/execution/ExecutionStrategy.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
Comment thread ...main/java/graphql/execution/instrumentation/dataloader/DataLoaderDispatchingContextKeys.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
Comment thread ...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
Comment thread ...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
Comment thread ...on/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategyWithDeferAlwaysDispatch.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
Comment thread src/main/java/graphql/schema/DataFetchingEnvironment.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
Comment thread src/test/groovy/graphql/MutationTest.groovy Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
Comment thread src/test/groovy/graphql/execution/instrumentation/dataloader/DataLoaderPerformanceTest.groovy Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman reviewed May 1, 2025
View reviewed changes
Comment thread ...main/java/graphql/execution/instrumentation/dataloader/DataLoaderDispatchingContextKeys.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman requested changes May 1, 2025
View reviewed changes

@bbakerman bbakerman left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change for tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
andimarek added 9 commits May 2, 2025 09:55
@andimarek
implement toInternal by default
604f679
@andimarek
formatting
6328062
@andimarek
cleanup
65cc42a
@andimarek
cleanup
51f9344
@andimarek
cleanup
d1384e1
@andimarek
cleanup
5b04714
@andimarek
PR feedback
a622d0d
@andimarek
PR feedback
cdb335f
@andimarek
PR feedback
81c4b09
bbakerman
bbakerman reviewed May 3, 2025
View reviewed changes
Comment thread src/main/java/graphql/schema/DataFetchingEnvironmentImpl.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
andimarek added 2 commits May 16, 2025 11:50
@andimarek
Merge branch 'master' into dataloader-cfs
4e0c26a
@andimarek
merging
c9a3ff3
@andimarek
andimarek merged commit c16cf96 into master May 16, 2025
@andimarek andimarek changed the title Enable DataLoader nesting/chaining Enable DataLoader chaining (nesting) Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbakerman bbakerman bbakerman requested changes
+1 more reviewer
@Hc747 Hc747 Hc747 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

25.x breaking changes

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@andimarek @bbakerman @Hc747 @dondonz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.