GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — JS like Batching by andimarek · Pull Request #3873 · graphql-java/graphql-java

Conversation

@andimarek

@andimarek andimarek commented Mar 30, 2025

Copy link
Copy Markdown
Member

This is a modified version of #3872

Probably the closest Java can get to the JS dataloader batching:

  • we track now if the engine is running in the ExecutionContext (regardless of thread)
  • a very small batch window of 0.1ms is started every time a new DataLoaderCF is created.
  • if the DatatLoaderCF encounters a running engine while trying to dispatch the time window resets to avoid dispatching while the engine is running

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
andimarek added 3 commits March 30, 2025 18:21
@andimarek
introducing of a special CompletableFuture enabling scheduling of nes…
0a27e76 
…ted/chained DataLoader calls
@andimarek
replace countdown latch with an async solution
f655893
@andimarek
only use window batching for DataLoaderCFs
dc19532
@github-actions

github-actions Bot commented Mar 30, 2025

Copy link
Copy Markdown
Contributor

Test Results

  312 files    312 suites   51s ⏱️
3 580 tests 3 573 ✅ 6 💤 1 ❌
3 669 runs  3 662 ✅ 6 💤 1 ❌

For more details on these failures, see this check.

Results for commit dc19532.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dondonz dondonz added this to the 23.1 non-breaking changes and bugfixes milestone Mar 31, 2025
@andimarek andimarek closed this Apr 1, 2025
@dondonz dondonz removed this from the 25.x breaking changes milestone Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@andimarek @dondonz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.