GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — A generalised configuration mechanism by bbakerman · Pull Request #3945 · graphql-java/graphql-java

Conversation

@bbakerman

@bbakerman bbakerman commented May 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Discoverability of how to config special parts of graphql-java is low

This tries to centralise that by providing a simple DSL and a common place to set both JVM wide and execution specific configuration

This is currently

        def builder = GraphQLContext.newContext()
        GraphQL.configuration().incrementalSupport().enableIncrementalSupport(builder, true)

but it could be

        def builder = GraphQLContext.newContext()
        GraphQL.configuration.incrementalSupport.enableIncrementalSupport(builder, true)

or

GraphQLConfiguration.IncrementalSupport.enableIncrementalSupport(builder, true)

but I kinda like how it comes off the GraphQl object for discoverability

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bbakerman
A generalised configuration mechanism
b5f2ab1
@bbakerman
bbakerman requested a review from andimarek May 1, 2025 08:47
bbakerman
bbakerman commented May 1, 2025
View reviewed changes
Comment thread src/main/java/graphql/GraphQLConfiguration.java Outdated
* including some JVM wide settings and some per execution settings
* as well as experimental ones
*/
public class GraphQLConfiguration {

@bbakerman bbakerman May 1, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other name suggestion GraphQlSettings and hence the name of GraphQl.configuration() would change

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bbakerman
bbakerman commented May 1, 2025
View reviewed changes
Comment thread src/main/java/graphql/parser/ParserOptions.java
* This static can be set to true to allow the behavior of version 16.x or before.
*
* @param options - the new default JVM parser options for operation parsing
* @param options - the new default JVM parser options for SDL parsing

@bbakerman bbakerman May 1, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a java doc mistake

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions

github-actions Bot commented May 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Test Results

  316 files    316 suites   2m 26s ⏱️
3 654 tests 3 649 ✅ 5 💤 0 ❌
3 743 runs  3 738 ✅ 5 💤 0 ❌

Results for commit 3c5c911.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bbakerman
bbakerman commented May 1, 2025
View reviewed changes
Comment thread src/main/java/graphql/GraphQLConfiguration.java Outdated
return INCREMENTAL_SUPPORT_CFG;
}

public static class ParserCfg {

@bbakerman bbakerman May 1, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parse config here is repeated - so sure you can go direct to ParserOptions and thats not too bad a name to discover

BUT

This makes it central and future ones can be here

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bbakerman added 6 commits May 1, 2025 18:59
@bbakerman
A generalised configuration mechanism - added property data fetcher c…
516b625 
…onfig
@bbakerman
Merge remote-tracking branch 'origin/master' into static-configuratio…
398c343 
…n-support
@bbakerman
A generalised configuration mechanism - tweaked name and cleanups in …
5700fe8 
…tests
@bbakerman
A generalised configuration mechanism - changed it to have graphql co…
fb67c76 
…ntext wrapping mechanism
@bbakerman
A generalised configuration mechanism - changed it to have graphql co…
b6313b1 
…ntext wrapping mechanism - renamed as extraordinary
@bbakerman
A generalised configuration mechanism - changed it to have graphql co…
f4b3c3f 
…ntext wrapping mechanism - renamed as unusual
@bbakerman bbakerman mentioned this pull request May 5, 2025
ResponseMapFactory #3857 #3894
Merged
@bbakerman
A generalised configuration mechanism - changed it to have graphql co…
2f9728e 
…ntext wrapping mechanism - renamed as config
@bbakerman bbakerman mentioned this pull request May 6, 2025
Response factory as config #3950
Merged
@dondonz dondonz modified the milestones: 24.0, 25.x breaking changes May 11, 2025
bbakerman added 3 commits May 19, 2025 12:02
@bbakerman
Merge remote-tracking branch 'origin/master' into static-configuratio…
ddf6ac1 
…n-support
@bbakerman
Added data loader config
bdb351a
@bbakerman
Added ExecutionInput support
3c5c911
andimarek
andimarek approved these changes May 19, 2025
View reviewed changes
@bbakerman
bbakerman merged commit f1a512c into master May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andimarek andimarek andimarek approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

25.x breaking changes

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bbakerman @andimarek @dondonz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.