GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Response factory as config by bbakerman · Pull Request #3950 · graphql-java/graphql-java

Conversation

@bbakerman

@bbakerman bbakerman commented May 6, 2025

Copy link
Copy Markdown
Member

This depends on #3945

But this removes the GraphQL aspect of ResponseMapFactory and makes it per context

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dfa1 reacted with eyes emoji
All reactions
  • 👀 1 reaction
bbakerman added 2 commits May 6, 2025 16:39
@bbakerman
Merge remote-tracking branch 'origin/static-configuration-support' in…
747736d
…to response-factory-as-config
@bbakerman
responseMapFactory now set via unusual configuration
1e6e0af
@bbakerman bbakerman added this to the 24.0 milestone May 6, 2025
@github-actions

github-actions Bot commented May 6, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Test Results

  318 files  ±0    318 suites  ±0   2m 32s ⏱️ +2s
4 678 tests +1  4 669 ✅ +1  9 💤 ±0  0 ❌ ±0 
4 767 runs  +1  4 758 ✅ +1  9 💤 ±0  0 ❌ ±0 

Results for commit 358c540. ± Comparison against base commit 2b26495.

This pull request removes 174 and adds 153 tests. Note that renamed tests count towards both.
	?
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
                a2 :  __type(name : "t1") { name }
…
graphql.DataFetcherTest ‑ get Boolean property value [fetcher: <graphql.schema.PropertyDataFetcher@6ff0b1cc propertyName=booleanField function=null>, #0]
graphql.DataFetcherTest ‑ get Boolean property value [fetcher: <graphql.schema.SingletonPropertyDataFetcher@2262d6d5>, #1]
graphql.DataFetcherTest ‑ get Boolean property value with get [fetcher: <graphql.schema.PropertyDataFetcher@3ba3d4b6 propertyName=booleanFieldWithGet function=null>, #0]
graphql.DataFetcherTest ‑ get Boolean property value with get [fetcher: <graphql.schema.SingletonPropertyDataFetcher@2262d6d5>, #1]
graphql.DataFetcherTest ‑ get property value [fetcher: <graphql.schema.PropertyDataFetcher@642857e0 propertyName=property function=null>, #0]
graphql.DataFetcherTest ‑ get property value [fetcher: <graphql.schema.SingletonPropertyDataFetcher@2262d6d5>, #1]
graphql.DataFetcherTest ‑ get public field value as property [fetcher: <graphql.schema.PropertyDataFetcher@6088451e propertyName=publicField function=null>, #0]
graphql.DataFetcherTest ‑ get public field value as property [fetcher: <graphql.schema.SingletonPropertyDataFetcher@2262d6d5>, #1]
graphql.ScalarsBooleanTest ‑ parseValue throws exception for invalid input <java.lang.Object@551b0266>
graphql.ScalarsBooleanTest ‑ serialize throws exception for invalid input <java.lang.Object@255d8982>
…

♻️ This comment has been updated with latest results.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dondonz dondonz modified the milestones: 24.0, 25.x breaking changes May 12, 2025
@bbakerman
Merge remote-tracking branch 'origin/master' into response-factory-as…
358c540
…-config

# Conflicts:
#	src/main/java/graphql/GraphQLUnusualConfiguration.java
#	src/main/java/graphql/execution/Execution.java
#	src/test/groovy/graphql/config/GraphQLUnusualConfigurationTest.groovy
@bbakerman
bbakerman merged commit 8218dd0 into master Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

25.x breaking changes

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bbakerman @dondonz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.