GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — OSGI - Make org.jspecify.* imports optional by schulm · Pull Request #3949 · graphql-java/graphql-java

Conversation

@schulm

@schulm schulm commented May 5, 2025

Copy link
Copy Markdown

Since org.specify import is not necessarily needed at runtime, can we make it optional?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Martin Schulze
OSGI - Make org.jspecify.* imports optional
5039753
@andimarek

andimarek commented May 5, 2025

Copy link
Copy Markdown
Member

@schulm sounds reasonable.

@dondonz @bbakerman thoughts?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bbakerman

bbakerman commented May 6, 2025

Copy link
Copy Markdown
Member

Yeah we should add this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bbakerman
bbakerman self-requested a review May 6, 2025 00:38
bbakerman
bbakerman approved these changes May 6, 2025
View reviewed changes

@bbakerman bbakerman left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not many use OSGI any more but why not

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bbakerman bbakerman added this to the 24.0 milestone May 6, 2025
@bbakerman
bbakerman merged commit 5f07138 into graphql-java:master May 6, 2025
@schulm

schulm commented May 6, 2025

Copy link
Copy Markdown
Author

@bbakerman Thanks, would you also have a look at graphql-java/java-dataloader#194
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@schulm schulm mentioned this pull request May 8, 2025
Release process #3952
Closed
dondonz added a commit that referenced this pull request May 13, 2025
@dondonz
Add cherry pick of PR #3949
a7b4f04
@dondonz dondonz mentioned this pull request May 13, 2025
24.x Cherry pick JSpecify OSGI config #3960
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbakerman bbakerman bbakerman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

24.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@schulm @andimarek @bbakerman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.