GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — #4190 - AST directives holder has a toString() by bbakerman · Pull Request #4195 · graphql-java/graphql-java

Conversation

@bbakerman

@bbakerman bbakerman commented Dec 18, 2025

Copy link
Copy Markdown
Member

See #4190

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bbakerman
#4190 - directives holder has a toString()
97aba88
@bbakerman bbakerman added this to the 26.x breaking changes milestone Dec 18, 2025
@github-actions

github-actions Bot commented Dec 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Test Results

  327 files  ±0    327 suites  ±0   5m 8s ⏱️ ±0s
5 221 tests ±0  5 213 ✅ ±0  8 💤 ±0  0 ❌ ±0 
5 310 runs  ±0  5 302 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 97aba88. ± Comparison against base commit 021fe1b.

This pull request removes 171 and adds 147 tests. Note that renamed tests count towards both.
	?

	, expected: combo-\"\\\b\f\n\r\t, #4]
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
…
graphql.ScalarsBooleanTest ‑ parseValue throws exception for invalid input <java.lang.Object@621d2b35>
graphql.ScalarsBooleanTest ‑ serialize throws exception for invalid input <java.lang.Object@434b53a9>
graphql.ScalarsIDTest ‑ parseValue allows any object via String.valueOf <java.lang.Object@3f9d2074>
graphql.ScalarsIDTest ‑ serialize allows any object via String.valueOf <java.lang.Object@3382fcff>
graphql.ScalarsIntTest ‑ parseValue throws exception for invalid input <java.lang.Object@39c3587a>
graphql.ScalarsIntTest ‑ serialize throws exception for invalid input <java.lang.Object@4b32952e>
graphql.analysis.QueryTraverserTest ‑ builder doesn't allow null arguments [document: Document{definitions=[OperationDefinition{name='null', operation=QUERY, variableDefinitions=[], directives=[], selectionSet=SelectionSet{selections=[Field{name='foo', alias='null', arguments=[], directives=[], selectionSet=null}]}}]}, operationName: foo, root: Field{name='null', alias='null', arguments=[], directives=[], selectionSet=null}, rootParentType: Mock for type 'GraphQLObjectType', fragmentsByName: null, #2]
graphql.analysis.QueryTraverserTest ‑ builder doesn't allow null arguments [document: Document{definitions=[OperationDefinition{name='null', operation=QUERY, variableDefinitions=[], directives=[], selectionSet=SelectionSet{selections=[Field{name='foo', alias='null', arguments=[], directives=[], selectionSet=null}]}}]}, operationName: foo, root: Field{name='null', alias='null', arguments=[], directives=[], selectionSet=null}, rootParentType: null, fragmentsByName: [:], #3]
graphql.analysis.QueryTraverserTest ‑ builder doesn't allow null arguments [document: Document{definitions=[OperationDefinition{name='null', operation=QUERY, variableDefinitions=[], directives=[], selectionSet=SelectionSet{selections=[Field{name='foo', alias='null', arguments=[], directives=[], selectionSet=null}]}}]}, operationName: foo, root: Field{name='null', alias='null', arguments=[], directives=[], selectionSet=null}, rootParentType: null, fragmentsByName: null, #1]
graphql.analysis.QueryTraverserTest ‑ builder doesn't allow null arguments [document: Document{definitions=[OperationDefinition{name='null', operation=QUERY, variableDefinitions=[], directives=[], selectionSet=SelectionSet{selections=[Field{name='foo', alias='null', arguments=[], directives=[], selectionSet=null}]}}]}, operationName: null, root: Field{name='null', alias='null', arguments=[], directives=[], selectionSet=null}, rootParentType: null, fragmentsByName: null, #0]
…

♻️ This comment has been updated with latest results.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andimarek
andimarek merged commit 458d1e9 into master Jan 21, 2026
5 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bbakerman bbakerman mentioned this pull request Feb 19, 2026
Field#toString should include individual directives instead of DirectivesHolder object reference #4249
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

26.x is a breaking change release (ot...

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bbakerman @andimarek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.