Description

invliD

opened on Dec 9, 2025

Issue body actions

Describe the bug
#4027 introduced an unannounced breaking change in 25.0. Quite a few places that now contain a DirectivesHolder implicitly call toString on it in their own toString implementations. Before this change that worked just fine, because directives were just a list and lists tend to have reasonable toString implementations.

Here is one example:

graphql-java/src/main/java/graphql/language/ScalarTypeDefinition.java

Lines 116 to 121 in 021fe1b

	public String toString() {
	return "ScalarTypeDefinition{" +
	"name='" + name + '\'' +
	", directives=" + directives +
	'}';
	}

DirectivesHolder, however, does not have one, so all those other toString implementations no longer produce reasonable output.

To Reproduce
Create a ScalarTypeDefinition object. Call toString on it.

Actual output:

ScalarTypeDefinition{name='Int', directives=graphql.language.NodeUtil$DirectivesHolder@5c995dee}

Expected output (and actual output in 24.x):

ScalarTypeDefinition{name='Int', directives=[]}

Activity

1. bbakerman commented on Dec 10, 2025

   

   bbakerman

   on Dec 10, 2025

   Member

   More actions

   Since this is open source, perhaps you could put together a PR to help address this.
2. invliD commented on Dec 10, 2025

   

   invliD

   on Dec 10, 2025

   Author

   More actions

   I mostly wanted to gauge whether this would be acceptable. I'll contribute a change to fix this early next year, thank you!
3. bbakerman

   added a commit that references this issue on Dec 18, 2025

   #4190 - directives holder has a toString()

   97aba88
4. andimarek

   added a commit that references this issue on Jan 21, 2026

   Merge pull request #4195 from graphql-java/4190-directive-holder--to-…

   458d1e9
5. github-actions commented on Feb 9, 2026

   

   github-actionsBot

   on Feb 9, 2026 – with GitHub Actions

   Contributor

   More actions

   Hello, this issue has been inactive for 60 days, so we're marking it as stale. If you would like to continue this discussion, please comment within the next 30 days or we'll close the issue.
6. github-actions

   added

   Stale

   on Feb 9, 2026
7. bbakerman commented on Feb 10, 2026

   

   bbakerman

   on Feb 10, 2026

   Member

   More actions

   Done

   Reacted by Sebastian Brückner
8. bbakerman

   closed this as completedon Feb 10, 2026

Issue actions