GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixes the copying of schemas by bbakerman · Pull Request #702 · graphql-java/graphql-java

Conversation

@bbakerman

@bbakerman bbakerman commented Sep 9, 2017

Copy link
Copy Markdown
Member

Fixes the copying of schemas and also the fact you cant set field visibility on IDL schema creation runtime wiring

See #698

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bbakerman
Fixes the copying of schemas and also the fact you cant set field vis…
adfeae2 
…ibility on IDL schema creation runtime wiring
@bbakerman
bbakerman requested review from andimarek and kaqqao September 9, 2017 11:29
andimarek
andimarek approved these changes Sep 9, 2017
View reviewed changes
@andimarek andimarek added this to the 5.0 milestone Sep 11, 2017
@andimarek

andimarek commented Sep 11, 2017

Copy link
Copy Markdown
Member

@bbakerman any objections to get this merged?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bbakerman
bbakerman merged commit 12120e9 into graphql-java:master Sep 11, 2017
@andimarek andimarek modified the milestones: 4.2, 5.0 Sep 11, 2017
andimarek pushed a commit that referenced this pull request Sep 11, 2017
@bbakerman @andimarek
Fixes the copying of schemas and also the fact you cant set field vis…
f9e9e13 
…ibility on IDL schema creation runtime wiring (#702)

(cherry picked from commit 12120e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andimarek andimarek andimarek approved these changes
@kaqqao kaqqao Awaiting requested review from kaqqao

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bbakerman @andimarek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.