GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — OSGI - Make org.jspecify.* imports optional by schulm · Pull Request #194 · graphql-java/java-dataloader

OSGI - Make org.jspecify.* imports optional #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dondonz merged 1 commit into graphql-java:master from schulm:feature/org-jspecify-optional
May 11, 2025

Uh oh!

There was an error while loading. Please reload this page.
Merged

OSGI - Make org.jspecify.* imports optional #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
7259df9
OSGI - Make org.jspecify.* imports optional
May 5, 2025
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view

There are no files selected for viewing

3 changes: 3 additions & 0 deletions 3 build.gradle
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ jar {
'-exportcontents': 'org.dataloader.*',
'-removeheaders': 'Private-Package')
}
bnd('''
Import-Package: org.jspecify.annotations;resolution:=optional,*
''')
Comment thread

@dondonz dondonz May 11, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, your title mentions org.jspecify.* but this PR is only excluding annotations. In the corresponding GraphQL Java PR, org.specify.* is set as optional.

I've merged in this PR. Thanks for the PR!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
}

dependencies {
Expand Down
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.