GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add accessibility semantics and labels. by jcsteh · Pull Request #3058 · greasemonkey/greasemonkey

Conversation

jcsteh commented Oct 23, 2019

Copy link

Copy Markdown

Contributor

This makes Greasemonkey far more usable by screen reader users.

Even though keyboard navigation is implemented for the Monkey Menu, this change exposes it as buttons, rather than menu + menuitems. This is because unlike most menus, this menu contains headings, which doesn't fit the ARIA menu pattern. This way, screen reader users will be able to browse this like any other document and will be made aware of (and able to jump to) the headings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add accessibility semantics and labels.

0c6bfd4

This makes Greasemonkey far more usable by screen reader users.

Even though keyboard navigation is implemented for the Monkey Menu, this change exposes it as buttons, rather than menu + menuitems.
This is because unlike most menus, this menu contains headings, which doesn't fit the ARIA menu pattern.
This way, screen reader users will be able to browse this like any other document and will be made aware of (and able to jump to) the headings.

This was referenced Oct 23, 2019

Expose sections as dialogs for accessibility. #3059

Merged

Improve accessibility #2639

Closed

arantius added this to the 4.10 milestone

Oct 25, 2019

MarcoZehe commented May 14, 2020

Copy link

Copy Markdown

Is there any way to move this forward? This PR has been sitting here uncommented and unreviewed for several months.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

arantius merged commit 7c0ed7a into greasemonkey:master

Sep 9, 2020

arantius commented Sep 9, 2020

Copy link

Copy Markdown

Collaborator

I just wanted to comment to say: thanks so much for your contribution, sorry that it took so long to get to addressing it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.10

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.