GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Expose sections as dialogs for accessibility. by jcsteh · Pull Request #3059 · greasemonkey/greasemonkey

Conversation

@jcsteh

@jcsteh jcsteh commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

Previously, screen readers reported nothing when the user switched to a new section. With this change, each section is exposed as a dialog, with the active dialog getting focus. This way, a screen reader will report the content of the new section as if a dialog appeared.

I separated this from #3058 because this one is a bit more controversial, since it messes with focus a tiny bit. Also, I'm totally blind, so I can't confirm whether focusing the sections causes problems visually.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jcsteh
Expose sections as dialogs for accessibility.
30eff7a 
Previously, screen readers reported nothing when the user switched to a new section.
With this change, each section is exposed as a dialog, with the active dialog getting focus.
This way, a screen reader will report the content of the new section as if a dialog appeared.
@jcsteh jcsteh mentioned this pull request Oct 23, 2019
Improve accessibility #2639
Closed
@MarcoZehe

MarcoZehe commented May 14, 2020

Copy link
Copy Markdown

Any way to move this forward? This PR has been sitting open and unreviewed for several months.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arantius arantius added this to the 4.10 milestone Sep 9, 2020
@arantius
arantius merged commit 99501e3 into greasemonkey:master Sep 9, 2020
@arantius

arantius commented Sep 9, 2020

Copy link
Copy Markdown
Collaborator

I just wanted to comment to say: thanks so much for your contribution, sorry that it took so long to get to addressing it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.10

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jcsteh @MarcoZehe @arantius
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.