GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add an optional simple editor which uses a plain textarea. by jcsteh · Pull Request #3060 · greasemonkey/greasemonkey

Conversation

@jcsteh

@jcsteh jcsteh commented Oct 24, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is needed by screen reader users, as CodeMirror is unfortunately not accessible. Having a separate editor is not ideal, nor is the missing functionality for screen reader users. Nevertheless, this is far better than a completely inaccessible editor. This at least allows screen reader users to read the content and do basic editing.

A more ideal alternative would be switching to Monaco, which is accessible. This would avoid the need for a separate editor and provide advanced functionality for all users. I'm not sure if that is feasible, though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AnnanFay reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@jcsteh
jcsteh force-pushed the a11ySimpleEditor branch from d788177 to e394a6d Compare October 24, 2019 03:26
@jcsteh

jcsteh commented Oct 24, 2019

Copy link
Copy Markdown
Contributor Author

I discovered that this broke when creating a new script, as the ?simple query string wasn't passed in that case. Fixing that was going to introduce more ugliness, so I refactored so that the options are fetched in edit-user-script. That should also make it easier to add additional editor configurability in future.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jcsteh jcsteh closed this Oct 24, 2019
@jcsteh jcsteh reopened this Oct 24, 2019
@jcsteh
Add an optional simple editor which uses a plain textarea.
304f55c 
This is needed by screen reader users, as CodeMirror is unfortunately not accessible.
Having a separate editor is not ideal, nor is the missing functionality for screen reader users.
Nevertheless, this is far better than a completely inaccessible editor.
This at least allows screen reader users to read the content and do basic editing.
@jcsteh
jcsteh force-pushed the a11ySimpleEditor branch from e394a6d to 304f55c Compare October 24, 2019 06:24
@arantius arantius added this to the 4.10 milestone Oct 25, 2019
@arantius

arantius commented Oct 25, 2019

Copy link
Copy Markdown
Collaborator

Monaco looks interesting and this example makes me think that if we include its files the right way, we can load it from a web extension.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MarcoZehe

MarcoZehe commented May 14, 2020

Copy link
Copy Markdown

Any way to move this forward? This PR has been sitting here largely uncommented and unreviewed for several months.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arantius
arantius merged commit 5be1d6c into greasemonkey:master Sep 9, 2020
@arantius

arantius commented Sep 9, 2020

Copy link
Copy Markdown
Collaborator

I just wanted to comment to say: thanks so much for your contribution, sorry that it took so long to get to addressing it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
arantius added a commit that referenced this pull request Sep 11, 2020
@arantius
Simple editor: appearance.
f7faa2b 
Fill the screen, monospace font.

Refs #3060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.10

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jcsteh @arantius @MarcoZehe
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.