GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replace pkg resources use by loqs · Pull Request #594 · html5lib/html5lib-python

Conversation

@loqs

@loqs loqs commented Mar 16, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
  • setup.py: except ImportError for missing pkg_resources
    • Missing pkg_resources indicates setuptools 82 or newer which is more recent that than 18.5 so the version check using pkg_resources can safely be skipped.
    • This is an alternative to setup.py: handle missing pkg_resources import #592 that avoids using setuptools internal namespace setuptools._vendor.packaging.version.
    • Fixes setuptools > 81 doesn't include pkg_resources #593.
  • conftest.py: Replace pkg_resources use with packaging
    • This is python 3+ only and intended to be merged after Only support python versions that receive security updates #580
    • I can refactor it so it supports 2.7+ if desired.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
a-detiste reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
loqs added 2 commits March 17, 2026 18:30
@loqs
setup.py: except ImportError for missing pkg_resources
ba50563 
Missing pkg_resources indicates setuptools 82 or newer which is more recent that than 18.5 so the version check using pkg_resources can safely be skipped.
@loqs
conftest.py: Replace pkg_resources use with packaging
41f8aa0
@loqs
loqs force-pushed the replace-pkg_resources-use branch from 6a82592 to 41f8aa0 Compare March 17, 2026 18:30
@hroncok

hroncok commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Thank you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@loqs

loqs commented Mar 19, 2026

Copy link
Copy Markdown
Author

@hroncok appveyor appears to be failing for two reasons:

  • py27-optional fails because "Microsoft Visual C++ 9.0" was removed from the "Visual Studio 2022" image which is needed to compile lxml-5.0.2.
  • py37-base and py37-optional fail because the Python 3.7 support was removed from the "Visual Studio 2022" image so tox can not run on it.

The py27-optional may be fixable by switching to the "Visual Studio 2015" image. Python 3.7 might require using a source build.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kdesysadmin pushed a commit to KDE/craft-blueprints-kde that referenced this pull request Jun 10, 2026
@mgallien
fix: fix build of html5lib by applying a patch
7e2e57b 
patch taken from html5lib/html5lib-python#594
issue html5lib/html5lib-python#593

Signed-off-by: Matthieu Gallien <[email protected]>
mgallien added a commit to nextcloud/craft-blueprints-kde that referenced this pull request Jun 10, 2026
@mgallien
fix: fix build of html5lib by applying a patch
23f22f4 
patch taken from html5lib/html5lib-python#594
issue html5lib/html5lib-python#593

Signed-off-by: Matthieu Gallien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

setuptools > 81 doesn't include pkg_resources

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@loqs @hroncok
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.