GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [PNDM] Stable diffusion by patrickvonplaten · Pull Request #186 · huggingface/diffusers

Conversation

@patrickvonplaten

@patrickvonplaten patrickvonplaten commented Aug 16, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR allows to use the PNDM scheduler without the prk steps so that it matches 1-to-1 @crowsonkb implementation as shown here.

As soon as a new diffusers version is released, we have to add a flag "skip_prk_ steps" to all stable diffusion configs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
patrickvonplaten added 2 commits August 16, 2022 13:16
@patrickvonplaten
[PNDM] Stable diffusino
6d973b6
@patrickvonplaten
finish
6388d4e
@patrickvonplaten patrickvonplaten changed the title [PNDM] Stable diffusino [PNDM] Stable diffusion Aug 16, 2022
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Aug 16, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
patrickvonplaten
patrickvonplaten commented Aug 16, 2022
View reviewed changes
Comment thread src/diffusers/schedulers/scheduling_pndm.py
beta_end=0.02,
beta_schedule="linear",
tensor_format="pt",
skip_prk_steps=False,

@patrickvonplaten patrickvonplaten Aug 16, 2022

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should default to True for all stable diffusion models

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anton-l reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
anton-l
anton-l approved these changes Aug 16, 2022
View reviewed changes

@anton-l anton-l left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactor, thank you Patrick!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/diffusers/schedulers/scheduling_pndm.py
Comment on lines +206 to +209
elif len(self.ets) == 3:
model_output = (23 * self.ets[-1] - 16 * self.ets[-2] + 5 * self.ets[-3]) / 12
else:
model_output = (1 / 24) * (55 * self.ets[-1] - 59 * self.ets[-2] + 37 * self.ets[-3] - 9 * self.ets[-4])

@anton-l anton-l Aug 16, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks much more familiar :D

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@patrickvonplaten

patrickvonplaten commented Aug 16, 2022

Copy link
Copy Markdown
Contributor Author

Tests are passing - merging now!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@patrickvonplaten
patrickvonplaten merged commit 194ed79 into main Aug 16, 2022
@patrickvonplaten
patrickvonplaten deleted the add_stable_diffusion_pndm branch August 16, 2022 13:33
PhaneeshB pushed a commit to nod-ai/diffusers that referenced this pull request Mar 1, 2023
@monorimet
Merge pull request huggingface#186 from nod-ai/benchmarks
fa6f196 
Make PyTorch model tests importer-independent and add benchmarks.
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@patrickvonplaten
[PNDM] Stable diffusion (huggingface#186)
5201097 
* [PNDM] Stable diffusino

* finish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anton-l anton-l anton-l approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@patrickvonplaten @HuggingFaceDocBuilderDev @anton-l
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.