GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add abstract client tests by shashank11p · Pull Request #246 · hypertrace/javaagent

Conversation

shashank11p commented Jan 29, 2021 •

edited by pavolloffay

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Updates #98

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          adding AbstractHttpClientTest and an echo target in TestHttpServer

f84f83d

shashank11p requested a review from pavolloffay

January 29, 2021 13:30


          updating AbstractHttpClientTest

029e2dd

pavolloffay reviewed

Feb 1, 2021

View reviewed changes

pavolloffay left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

shashank11p added 2 commits

February 1, 2021 17:46


          updating AbstractHttpClientTest

d775706


          updating okHttp and apache http client tests

b7190b2

shashank11p requested a review from pavolloffay

February 2, 2021 07:32

pavolloffay reviewed

Feb 2, 2021

View reviewed changes

Comment thread

...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

pavolloffay changed the title ~~Adding AbstractHttpClientTest class for Http client tests~~ Add abstract client tests

Feb 2, 2021


          review comments, refactoring

7cbcb85

shashank11p requested a review from pavolloffay

February 2, 2021 08:31

pavolloffay reviewed

Feb 2, 2021

View reviewed changes

Comment thread

...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.


          review comments and removing apache async http client changes

a405879

shashank11p requested a review from pavolloffay

February 2, 2021 12:35

shashank11p marked this pull request as ready for review

February 2, 2021 12:39

pavolloffay reviewed

Feb 2, 2021

View reviewed changes

Comment thread

...nt/instrumentation/hypertrace/apachehttpclient/v4_0/ApacheHttpClientInstrumentationTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.


          review comments

e163156

shashank11p requested a review from pavolloffay

February 3, 2021 05:09

pavolloffay approved these changes

Feb 3, 2021

View reviewed changes

pavolloffay merged commit 8275b70 into main

Feb 3, 2021

pavolloffay deleted the ENG-7540/abstractHttpClientTest branch

February 3, 2021 09:14

shashank11p added a commit to shashank11p/javaagent that referenced this pull request

Feb 3, 2021


          Merge pull request #2 from hypertrace/main

9aa407a

Add abstract client tests (hypertrace#246)

Reviewers

pavolloffay

pavolloffay approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

shashank11p commented Jan 29, 2021 • edited by pavolloffay Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pavolloffay left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shashank11p commented Jan 29, 2021 •

edited by pavolloffay

Loading

Uh oh!

There was an error while loading. Please reload this page.