GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Added JASPIC tests that test whether a SAM can forward and include by arjantijms · Pull Request #303 · javaee-samples/javaee7-samples

Conversation

@arjantijms

@arjantijms arjantijms commented May 19, 2015

Copy link
Copy Markdown
Contributor

several kinds of resources

Tested on JBoss WildFly 8.2, GlassFish 4.1 and (with a small local modification) on WebLogic 12.1.3 (which is Java EE 6).

Several tests fail on each server. I'll be creating issues for them and in case of Mojarra probably look at fixing it myself (if it turns out to be Mojarra issue).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@arjantijms
Added JASPIC tests that test whether a SAM can forward and include
6a22709
several kinds of resources
@arjantijms

arjantijms commented May 20, 2015

Copy link
Copy Markdown
Contributor Author

p.s. failed checks are in totally unrelated batch tests, see:

Caused by: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at org.apache.openjpa.enhance.ClassRedefiner.redefineClasses(ClassRedefiner.java:85)
... 34 more
Caused by: java.lang.VerifyError
at sun.instrument.InstrumentationImpl.retransformClasses0(Native Method)
at sun.instrument.InstrumentationImpl.retransformClasses(InstrumentationImpl.java:144)
... 39 more

May 19, 2015 11:13:22 PM org.apache.openejb.assembler.classic.Assembler destroyApplication
INFO: Undeploying app: /tmp/arquillian-tomee-app-working-dir/0/325e2b7d-ab22-4858-8491-3adb1b62e600
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 21.966 sec <<< FAILURE! - in org.javaee7.batch.chunk.csv.database.BatchCSVDatabaseTest
testBatchCSVDatabase(org.javaee7.batch.chunk.csv.database.BatchCSVDatabaseTest) Time elapsed: 11.186 sec <<< FAILURE!
java.lang.AssertionError: expected:<7> but was:<3>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:555)
at org.junit.Assert.assertEquals(Assert.java:542)
at org.javaee7.batch.chunk.csv.database.BatchCSVDatabaseTest.testBatchCSVDatabase(BatchCSVDatabaseTest.java:108)

May 19, 2015 11:13:22 PM sun.reflect.NativeMethodAccessorImpl invoke
INFO: Stopping ProtocolHandler ["http-bio-8080"]
May 19, 2015 11:13:22 PM sun.reflect.NativeMethodAccessorImpl invoke
INFO: Pausing ProtocolHandler ["http-bio-8080"]
May 19, 2015 11:13:22 PM sun.reflect.NativeMethodAccessorImpl invoke
INFO: Stopping service Tomcat
May 19, 2015 11:13:22 PM org.apache.openejb.assembler.classic.Assembler destroyResource
INFO: Closing DataSource: Default JDBC Database
May 19, 2015 11:13:22 PM org.apache.openejb.assembler.classic.Assembler destroyResource
INFO: Closing DataSource: Default Unmanaged JDBC Database
May 19, 2015 11:13:22 PM sun.reflect.NativeMethodAccessorImpl invoke
INFO: Destroying ProtocolHandler ["http-bio-8080"]

Results :

Failed tests:
BatchCSVDatabaseTest.testBatchCSVDatabase:108 expected:<7> but was:<3>

Tests run: 1, Failures: 1, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Java EE 7 Sample: javaee7-samples .................. SUCCESS [ 44.902 s]
[INFO] Java EE 7 Sample: javaee7-samples - test-utils ..... SUCCESS [ 1.860 s]
[INFO] Java EE 7 Sample: javaee7-samples - util ........... SUCCESS [ 2.675 s]
[INFO] Java EE 7 Sample: batch ............................ SUCCESS [ 0.208 s]
[INFO] Java EE 7 Sample: batch - batchlet-simple .......... SUCCESS [ 23.287 s]
[INFO] Java EE 7 Sample: batch - chunk-checkpoint ......... SUCCESS [ 18.707 s]
[INFO] Java EE 7 Sample: batch - chunk-csv-database ....... FAILURE [ 24.650 s]

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arjantijms
Added tests for a custom principal and
f845342
HttpServletRequest.getUserPrincipal
@arun-gupta

arun-gupta commented May 21, 2015

Copy link
Copy Markdown
Contributor

chunk-csv-database is failing?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arjantijms

arjantijms commented May 22, 2015

Copy link
Copy Markdown
Contributor Author

chunk-csv-database is failing?

Not 100% sure what is failing here, looks like something with the JPA class enhancer.

But it is a test that's failing, and of course more than a few tests fail (because of bugs in the server, or unsupported features).

The Travis CI build now aborts on the first test failure, which is what you would expect for builds in say a business project (they are supposed to have 0 failures). But for this project having a couple of failing tests is more or less the intention.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

arjantijms added a commit that referenced this pull request May 22, 2015
@arjantijms
Merge pull request #303 from arjantijms/jaspic
557de80
Added JASPIC tests that test whether a SAM can forward and include
@arjantijms
arjantijms merged commit 557de80 into javaee-samples:master May 22, 2015
@arjantijms arjantijms mentioned this pull request May 26, 2015
Pull Requests/Merge to master #306
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@arjantijms @arun-gupta
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.