GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Symbol type by mariabp · Pull Request #115 · javascript-tutorial/es.javascript.info

Conversation

mariabp commented Oct 22, 2019

Copy link

Copy Markdown

Translation to spanish ready to review :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          First translation

6f952dc

javascript-translate-bot added the review needed label

Oct 22, 2019

javascript-translate-bot requested a review from a team

October 22, 2019 15:33

CLAassistant commented Oct 22, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ mariabp
✅ vplentinax
❌ Developer

Developer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lizzie136 requested changes

Oct 29, 2019

View reviewed changes

lizzie136 left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @mariabp
esta super genial la traducción, solo hay un pequeño detalle,
en todas las declaraciones le agregaste un espacio extra.
Por ejemplo:
let id = Symbol("id"); , debería ser let id = Symbol("id"); (le quité un espacio entre el let y el id

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mariabp reacted with thumbs up emoji

All reactions

👍 1 reaction

javascript-translate-bot added changes requested and removed review needed labels

Oct 29, 2019

javascript-translate-bot commented Oct 29, 2019

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mariabp and others added 2 commits

November 1, 2019 11:35


          Update article.md

de0b438

Listo! Ya eliminé los espacios extras, que raro que los puse 🤔 . 
Me dices que te parece :)


          Deleted extra space between declaration and name of variable

0a786f0

mariabp commented Nov 8, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Author

Done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lizzie136 added review needed and removed changes requested labels

Nov 15, 2019

lizzie136 self-requested a review

November 15, 2019 15:50

lizzie136 approved these changes

Nov 15, 2019

View reviewed changes

lizzie136 left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Nov 15, 2019

lizzie136 requested review from caballerof and tscandalitta

November 15, 2019 15:51

tscandalitta reviewed

Nov 20, 2019

View reviewed changes

Comment thread

1-js/04-object-basics/03-symbol/article.md Outdated

		```

		Symbols are guaranteed to be unique. Even if we create many symbols with the same description, they are different values. The description is just a label that doesn't affect anything.
		Los Symbols están garantizados a ser únicos. Aunque declaremos varios Symbols con la misma descripción éstos tendrán valores distintos. La descripción es solamente una etiqueta que no afecta nada más.

tscandalitta Nov 20, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Se garantiza que los símbolos son únicos" me parece que suena más natural, lo dejo a tu criterio.
"Aunque declaremos varios Symbols con la misma descripción, éstos ..."

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mariabp Nov 24, 2019

Copy link

Copy Markdown

Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Estoy de acuerdo contigo!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tscandalitta reviewed

Nov 20, 2019

View reviewed changes

Comment thread

1-js/04-object-basics/03-symbol/article.md Outdated


		````warn header="Symbols don't auto-convert to a string"
		Most values in JavaScript support implicit conversion to a string. For instance, we can `alert` almost any value, and it will work. Symbols are special. They don't auto-convert.
		````warn header="Symbols no se auto convierten a String"

tscandalitta Nov 20, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto-convierten, para ser consistentes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tscandalitta reviewed

Nov 20, 2019

View reviewed changes

Comment thread

1-js/04-object-basics/03-symbol/article.md Outdated

		## Propiedades "Ocultas"

		Symbols allow us to create "hidden" properties of an object, that no other part of code can occasionally access or overwrite.
		Los Symbols nos permiten crear propiedades "ocultas" en un objeto, las cuales ninguna otra parte del código puede accesar ni sobre-escribir.

tscandalitta Nov 20, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Los Symbols nos permiten crear propiedades "ocultas" en un objeto, a las cuales ninguna otra parte del código puede acceder ni sobre-escribir.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tscandalitta commented Nov 20, 2019

Copy link

Copy Markdown

Collaborator

No se debe traducir los nombres de las variables, por ejemplo de "user" a "usuario"

Don't translate variables, classes, identifiers.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax changed the title ~~First translation~~ Symbol type

Jun 7, 2020

iliakan mentioned this pull request

Jun 7, 2020

Spanish Translation Progress #17

Open

vplentinax requested review from EzequielCaste and joaquinelio

June 7, 2020 19:21

vplentinax commented Jun 7, 2020

Copy link

Copy Markdown

Contributor

Revisenlo para yo agregar los cambios y no tener que volverlos a revisar una vez arregle el conflicto de estructura.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio requested changes

Jun 8, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezzep66
te lo paso porque puse varias cosas

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Jun 8, 2020

vplentinax and others added 5 commits

June 10, 2020 00:54


          Update 1-js/04-object-basics/03-symbol/article.md

239004b

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/04-object-basics/03-symbol/article.md

969795a

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/04-object-basics/03-symbol/article.md

82a0bb0

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/04-object-basics/03-symbol/article.md

68d693c

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/04-object-basics/03-symbol/article.md

505e32b

Co-authored-by: joaquinelio <[email protected]>

vplentinax commented Jun 10, 2020

Copy link

Copy Markdown

Contributor

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax and others added 3 commits

June 10, 2020 19:34


          Update 1-js/04-object-basics/03-symbol/article.md

5015fc3

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/04-object-basics/03-symbol/article.md

6ba4d07

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/04-object-basics/03-symbol/article.md

63349ea

Co-authored-by: joaquinelio <[email protected]>

vplentinax mentioned this pull request

Jun 13, 2020

Symbol type #252

Merged

vplentinax closed this

Jun 13, 2020

Reviewers

tscandalitta

tscandalitta left review comments

joaquinelio

joaquinelio requested changes

lizzie136

lizzie136 approved these changes

caballerof

Awaiting requested review from caballerof

EzequielCaste

Awaiting requested review from EzequielCaste

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

changes requested needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

mariabp commented Oct 22, 2019

Uh oh!

CLAassistant commented Oct 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lizzie136 left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Oct 29, 2019

Uh oh!

mariabp commented Nov 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lizzie136 left a comment

Choose a reason for hiding this comment

Uh oh!

tscandalitta Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

mariabp Nov 24, 2019

Choose a reason for hiding this comment

Uh oh!

tscandalitta Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

tscandalitta Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

tscandalitta commented Nov 20, 2019

Uh oh!

vplentinax commented Jun 7, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jun 8, 2020

Uh oh!

vplentinax commented Jun 10, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

CLAassistant commented Oct 22, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

mariabp commented Nov 8, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.