GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Symbol type by vplentinax · Pull Request #252 · javascript-tutorial/es.javascript.info

Conversation

vplentinax commented Jun 13, 2020

Copy link

Copy Markdown

Contributor

Este PR corresponde a la traducción del PR Symbol type #115 hecho por la usuaria @mariapb. Revisar.Dicho PR #115 será cerrado y editado en el Issue #17

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          mariabp-translate-symbol

98ad04b

javascript-translate-bot added the review needed label

Jun 13, 2020

javascript-translate-bot requested a review from a team

June 13, 2020 18:44

iliakan mentioned this pull request

Jun 13, 2020

Spanish Translation Progress #17

Open

javascript-tutorial deleted a comment from javascript-translate-bot

Jun 13, 2020

cortizg suggested changes

Jun 13, 2020

View reviewed changes

Comment thread

1-js/04-object-basics/08-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Jun 13, 2020

javascript-translate-bot commented Jun 13, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Jun 13, 2020

cortizg suggested changes

Jun 13, 2020

View reviewed changes

cortizg left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algunas observaciones

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/04-object-basics/08-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/08-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/08-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/08-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/08-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Jun 13, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio requested changes

Jun 14, 2020

View reviewed changes

Comment thread

1-js/04-object-basics/08-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/08-symbol/article.md Outdated

		user[id] = 1;

		alert( user[id] ); // we can access the data using the symbol as the key
		alert( user[id] ); // podemos accesar a la información utilizando symbol como propiedad

joaquinelio Jun 14, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	alert( user[id] ); // podemos accesar a la información utilizando symbol como propiedad
	alert( user[id] ); // podemos accesar a la información utilizando el symbol como clave

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/04-object-basics/08-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Jun 14, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax and others added 3 commits

June 16, 2020 12:09


          Update 1-js/04-object-basics/08-symbol/article.md

b86bda1

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/04-object-basics/08-symbol/article.md

b9fead4

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/04-object-basics/08-symbol/article.md

9fc3ad4

Co-authored-by: joaquinelio <[email protected]>

vplentinax commented Jun 16, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Jun 16, 2020

javascript-translate-bot requested a review from a team

June 16, 2020 16:11

joaquinelio requested changes

Jul 2, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vplentinax @ezzep66 @cortizg
Al toro por las... y seguir adelante.

En este particular artículo queda evidente que no va "key = property",
se confunde el nombre con la cosa o la llave con la caja, escribir propiedad/valor lleva a definición circular, son categorías diferentes y, ej: Mientras prop puede ser un boolean, key no.

En la mayoría de las referencias la distinción es superflua y puede pasar aunque no me guste, aunque acá la necesitamos.
Pero estaría mal usar "clave" si no se usa en el resto del curso. Así que refiguro
key (nombre de propiedad) / value (valor de propiedad)

Creo que el artículo quedó entendible. Si quieren cambiar, ok, me salgo de la discusión y sigo aportando con otras reviews. Que no nos frene.
FESTEJEMOS EL TERCIO DE REPO TRADUCIDO

NOTA: Quise añadir las sugerencias de c4 y no pude ¿como se hace suggest de una línea no traducida? Hay //comments no traducidos.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/04-object-basics/08-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/08-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/08-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/08-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/08-symbol/article.md Outdated

		# Tipo Symbol

		By specification, object property keys may be either of string type, or of symbol type. Not numbers, not booleans, only strings or symbols, these two types.
		Por especificación, las claves de un objeto deben ser solamente del tipo String o Symbol. Solamente esos dos: String o Symbol.

joaquinelio Jul 2, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	Por especificación, las claves de un objeto deben ser solamente del tipo String o Symbol. Solamente esos dos: String o Symbol.
	Por especificación, los nombres de propiedad (keys) de un objeto deben ser solamente del tipo String o Symbol. Solamente esos dos: String o Symbol.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/04-object-basics/08-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Jul 2, 2020

javascript-translate-bot commented Jul 2, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vplentinax and others added 6 commits

July 2, 2020 17:59


          Update 1-js/04-object-basics/08-symbol/article.md

c9b24e3

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/04-object-basics/08-symbol/article.md

adef69b

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/04-object-basics/08-symbol/article.md

da63be3

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/04-object-basics/08-symbol/article.md

ec2a0de

Co-authored-by: joaquinelio <[email protected]>


          Update 1-js/04-object-basics/08-symbol/article.md

d95aaa5

Co-authored-by: joaquinelio <[email protected]>


          Update article.md

En el glosario se estipuló key = clave. Así lo dejo y dejaré en próximas traducciones.

vplentinax commented Jul 2, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Jul 2, 2020

javascript-translate-bot requested a review from a team

July 2, 2020 22:33

javascript-translate-bot removed the review needed label

Jul 3, 2020

joaquinelio approved these changes

Jul 3, 2020

View reviewed changes

joaquinelio left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vplentinax

En el glosario se estipuló key = clave. Así lo dejo y dejaré en próximas traducciones.

¡De acuerdo!
Pero... Algo me perdí, insistí con clave pero me había cansado... Recuerdo la argumentacipn de eze sobre propiedad/valor, del ctl+F y el cuenta palabbras, deque era como se lo enseñaron...
Y veo qye lo repusiste< ¡hace dos semanas!

clave, perfecto. Es la llave con la que se accede al value de la propiedad.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added the needs +1 label

Jul 3, 2020

vplentinax merged commit d0b203c into javascript-tutorial:master

Jul 5, 2020

javascript-translate-bot commented Jul 5, 2020

Copy link

Copy Markdown

Error: the article has another translator @mariabp, not @vplentinax in the Progress Issue #17. Please update the progress issue or ask maintainers to do so.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

joaquinelio

joaquinelio approved these changes

+1 more reviewer

cortizg

cortizg requested changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.