GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Static properties and methods by cortizg · Pull Request #172 · javascript-tutorial/es.javascript.info

Conversation

@cortizg

@cortizg cortizg commented May 9, 2020

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cortizg
1-09-03 Traducido 2
e5d0638
@javascript-translate-bot javascript-translate-bot added the review needed label May 9, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team May 9, 2020 04:08
@javascript-translate-bot

javascript-translate-bot commented May 9, 2020

Copy link
Copy Markdown

Error: the article already has PR number in the Progress Issue #17, it's 167 ⁉️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cortizg

cortizg commented May 9, 2020

Copy link
Copy Markdown
Contributor Author

#172 replace #167
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cortizg cortizg mentioned this pull request May 10, 2020
Spanish Translation Progress #17
Open
@cortizg
Merge branch 'master' into es.javascript.info.1-09-03
32084d2
joaquinelio
joaquinelio requested changes Jun 21, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Está perfecta. O estoy ciego. Deberían coincidir las líneas, agregué 2 suggest.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/09-classes/03-static-properties-methods/article.md
alert( article.title ); // Today's digest
alert( article.title ); // Resumen de hoy
```
Ahora, cada vez que necesitamos crear un resumen de hoy, podemos llamar a `Article.createTodays()`. Una vez más, ese no es el método de un objeto artículo, sino el método de toda la clase.

@joaquinelio joaquinelio Jun 21, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ahora, cada vez que necesitamos crear un resumen de hoy, podemos llamar a `Article.createTodays()`. Una vez más, ese no es el método de un objeto artículo, sino el método de toda la clase.
Ahora, cada vez que necesitamos crear un resumen de hoy, podemos llamar a `Article.createTodays()`. Una vez más, ese no es el método de un objeto artículo, sino el método de toda la clase.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/09-classes/03-static-properties-methods/article.md
class Animal {
static planet = "Earth";

static planet = "Tierra";

@joaquinelio joaquinelio Jun 21, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
static planet = "Tierra";
static planet = "Tierra";

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot removed the review needed label Jun 21, 2020
@javascript-translate-bot

javascript-translate-bot commented Jun 21, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added the changes requested label Jun 21, 2020
@joaquinelio
joaquinelio merged commit 05f7589 into javascript-tutorial:master Jun 21, 2020
@javascript-translate-bot

javascript-translate-bot commented Jun 21, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@cortizg @javascript-translate-bot @joaquinelio
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.